axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepal Jayasinghe <dee...@opensource.lk>
Subject Re: svn commit: r417623 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java
Date Wed, 28 Jun 2006 04:47:17 GMT
Hi Chamikara;

You can not add any TransportOutDescription without having a
TransportSender , therefore sender object wont be null so you dont need
to check that :)
The problem for changing AxisEngine  (checking to address and so on )
was to support multiple transport scenario , after your change it DOES
NOT work. I can not send request using HTTP and get the via TCP, So I
have to revert your changes and I will add test case so that it will not
break in the future.

btw why did you change that ?

chamikara@apache.org wrote:

>Author: chamikara
>Date: Tue Jun 27 16:29:14 2006
>New Revision: 417623
>
>URL: http://svn.apache.org/viewvc?rev=417623&view=rev
>Log:
>Setting the sender based on the Scheme should happen only if has not already been set.since
some handler may hv purposely put this Sender to obtain certain behaviour.
>
>Modified:
>    webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java
>
>Modified: webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java
>URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java?rev=417623&r1=417622&r2=417623&view=diff
>==============================================================================
>--- webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java
(original)
>+++ webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/engine/AxisEngine.java
Tue Jun 27 16:29:14 2006
>@@ -617,8 +617,11 @@
>             // write the Message to the Wire
>             TransportOutDescription transportOut = msgContext.getTransportOut();
>             TransportSender sender = transportOut.getSender();
>+            
>             //there may be instance where you want to send the response to replyTo
>-            if (msgContext.isServerSide() && msgContext.getTo() != null) {
>+            //and this default behaviour should happen if somebody (e.g. a module) has
not already provided
>+            //a Sender.
>+            if (sender==null && msgContext.isServerSide() && msgContext.getTo()
!= null) {
>                 try {
>                     String replyToAddress = msgContext.getTo().getAddress();
>                     if (!(AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(replyToAddress)
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
>
>  
>

-- 
Thanks,
Deepal
................................................................
~Future is Open~ 



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Mime
View raw message