Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 11017 invoked from network); 8 Nov 2005 04:44:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Nov 2005 04:44:36 -0000 Received: (qmail 19672 invoked by uid 500); 8 Nov 2005 04:44:34 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 19061 invoked by uid 500); 8 Nov 2005 04:44:30 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 19033 invoked by uid 99); 8 Nov 2005 04:44:29 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2005 20:44:29 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of csethil@gmail.com designates 66.249.82.192 as permitted sender) Received: from [66.249.82.192] (HELO xproxy.gmail.com) (66.249.82.192) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2005 20:44:22 -0800 Received: by xproxy.gmail.com with SMTP id t16so616150wxc for ; Mon, 07 Nov 2005 20:44:07 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=e18E3YV8NNBo4TD5iNcvzOzSEnjgA0UsPtbVDLgB5g7mJQUQx59giGkeRIeV7yVrKwAjwwuD7x7iGA1UdEVEH+HRiuYTnNOEmLQqh2nhGo3TYYpQpLTKrXW0h3n/1YAMOxOvGKiibrHdAzIN0NdsYOT5WGjjVK+YMj1rIYKZ0sE= Received: by 10.70.46.5 with SMTP id t5mr1817440wxt; Mon, 07 Nov 2005 20:44:07 -0800 (PST) Received: by 10.70.13.1 with HTTP; Mon, 7 Nov 2005 20:44:06 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2005 10:44:06 +0600 From: Thilina Gunarathne To: axis-dev@ws.apache.org, dims@apache.org Subject: Re: svn commit: r331245 - in /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2: Constants.java context/MessageContextConstants.java transport/http/HTTPTransportUtils.java Cc: "chinthaka@apache.org" , axis2-cvs@ws.apache.org In-Reply-To: <19e0530f0511071125j469a4951w864eee6a70c576cd@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_47675_24772529.1131425046762" References: <20051107091237.48193.qmail@minotaur.apache.org> <19e0530f0511070118v48bd0853w461e488851fde04c@mail.gmail.com> <19e0530f0511071125j469a4951w864eee6a70c576cd@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_47675_24772529.1131425046762 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline cool... +1 We'll have it as MTOM is required... :D Dims, I read your blog entry and know what you are talking about ;-). Thanks, ~Thilina On 11/8/05, Davanum Srinivas wrote: > > thilina, > > i was kidding :) > > -- dims > > On 11/7/05, Thilina Gunarathne wrote: > > I'm 0- on this change.... > > Are we going to introduce inefficiencies cause Indigo has them. Anyway > it's > > better we put it as a option. But do we really need to do this... > > > > ~Thilina > > > > > > > > On 11/7/05, Davanum Srinivas wrote: > > > Can we use "OptimizedMimeSerialization" as the parameter name :) > > > > > > -- dims > > > > > > On 11/7/05, chinthaka@apache.org wrote: > > > > Author: chinthaka > > > > Date: Mon Nov 7 01:12:27 2005 > > > > New Revision: 331245 > > > > > > > > URL: http://svn.apache.org/viewcvs?rev=3D331245&view=3Drev > > > > Log: > > > > Fixing MTOM so that now we can force the message to be sent as > multipart > > related. > > > > > > > > Modified: > > > > > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/Constants.= java > > > > > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/Me= ssageContextConstants.java > > > > > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/= http/HTTPTransportUtils.java > > > > > > > > Modified: > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/Constants.= java > > > > URL: > > > http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/s= rc/org/apache/axis2/Constants.java?rev=3D331245&r1=3D331244&r2=3D331245&vie= w=3Ddiff > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > > > --- > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/Constants.= java > > (original) > > > > +++ > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/Constants.= java > > Mon Nov 7 01:12:27 2005 > > > > @@ -195,6 +195,9 @@ > > > > public static final String ATTACHMENT_TEMP_DIR =3D > > "attachmentDIR"; > > > > public static final String CACHE_ATTACHMENTS =3D > > "cacheAttachments"; > > > > public static final String FILE_SIZE_THRESHOLD =3D > > "sizeThreshold"; > > > > + > > > > + // we need to some times send the message as multipart/related, > > even if there is no MTOM stuff in the envelope. > > > > + public static final String FORCE_MIME =3D "ForceMimeBoundary"; > > > > } > > > > > > > > public static final String VALUE_TRUE =3D "true"; > > > > > > > > Modified: > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/Me= ssageContextConstants.java > > > > URL: > > > http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/s= rc/org/apache/axis2/context/MessageContextConstants.java?rev=3D331245&r1=3D= 331244&r2=3D331245&view=3Ddiff > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > > > --- > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/Me= ssageContextConstants.java > > (original) > > > > +++ > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/Me= ssageContextConstants.java > > Mon Nov 7 01:12:27 2005 > > > > @@ -21,5 +21,6 @@ > > > > public interface MessageContextConstants { > > > > > > > > // this will contain the keys of all the properties that will be in > > the message context > > > > > > > > > > > > > > > > + > > > > > > > > public static final String TRANSPORT_URL =3D "TransportURL"; > > > > > > > > } > > > > > > > > > > > > Modified: > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/= http/HTTPTransportUtils.java > > > > URL: > > > http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/s= rc/org/apache/axis2/transport/http/HTTPTransportUtils.java?rev=3D331245&r1= =3D331244&r2=3D331245&view=3Ddiff > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > > > --- > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/= http/HTTPTransportUtils.java > > (original) > > > > +++ > > > webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/= http/HTTPTransportUtils.java > > Mon Nov 7 01:12:27 2005 > > > > @@ -452,12 +452,13 @@ > > > > msgContext.getProperty( > > > > > > Constants.Configuration.ENABLE_MTOM)); > > > > } > > > > - boolean envelopeContainsOptimise =3D > > > > - > > HTTPTransportUtils.checkEnvelopeForOptimise( > > > > + > > > > + boolean forceMIME =3D > > Constants.VALUE_TRUE.equals(msgContext.getProperty( > Constants.Configuration.FORCE_MIME)); > > > > + if(forceMIME) return true; > > > > + > > > > + boolean envelopeContainsOptimise =3D > > HTTPTransportUtils.checkEnvelopeForOptimise( > > > > msgContext.getEnvelope()); > > > > - boolean doMTOM =3D enableMTOM && envelopeContainsOptimise; > > > > - msgContext.setDoingMTOM(doMTOM); > > > > - return doMTOM; > > > > + return enableMTOM && envelopeContainsOptimise; > > > > } > > > > > > > > public static boolean isDoingREST(MessageContext msgContext) { > > > > > > > > > > > > > > > > > > > > > -- > > > Davanum Srinivas : http://wso2.com/blogs/ > > > > > > > > > > > -- > > "May the SourcE be with u" > > http://webservices.apache.org/~thilina/ > > http://thilinag.blogspot.com/ > > http://www.bloglines.com/blog/Thilina > > > -- > Davanum Srinivas : http://wso2.com/blogs/ > -- "May the SourcE be with u" http://webservices.apache.org/~thilina/ http://thilinag.blogspot.com/ http://www.bloglines.com/blog/Thilina ------=_Part_47675_24772529.1131425046762 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
cool... +1
We'll have it as MTOM is required... :D
Dims,
 I read your blog entry and know what you are talking about ;-).<= /div>
 
 
Thanks,
~Thilina

 
On 11/8/05, = Davanum Srinivas <davanum@gmail= .com> wrote:
thilina,

i was kidding :)=

-- dims

On 11/7/05, Thilina Gunarathne < csethil@gmail.com> wrote:
> I'm 0- on this change....
> = Are we going to introduce inefficiencies cause Indigo has them. Anyway it's=
> better we put it as a option. But do we really need to do this...
>
> ~Thilina
>
>
>
> On 11/7/05, Davan= um Srinivas <davanum@gmail.com&= gt; wrote:
> > Can we use "OptimizedMimeSerialization" a= s the parameter name :)
> >
> > -- dims
> >
> > On 11/7/05, chinthaka@apache.org <chinthaka@apache.org> wrote:
>= ; > > Author: chinthaka
> > > Date: Mon Nov  7 01:12:27 2005
> > &g= t; New Revision: 331245
> > >
> > > URL: http://svn.apac= he.org/viewcvs?rev=3D331245&view=3Drev
> > > Log:
> > > Fixing MTOM so that now we ca= n force the message to be sent as multipart
> related.
> > &= gt;
> > > Modified:
> > >
> webservices/axis2= /trunk/java/modules/core/src/org/apache/axis2/Constants.java
> > >
> webservices/axis2/trunk/java/modules/core/src/or= g/apache/axis2/context/MessageContextConstants.java
> > >
&g= t; webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport= /http/HTTPTransportUtils.java
> > >
> > > Modified:
> webservices/axis2/tr= unk/java/modules/core/src/org/apache/axis2/Constants.java
> > >= URL:
> http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/src= /org/apache/axis2/Constants.java?rev=3D331245&r1=3D331244&r2=3D3312= 45&view=3Ddiff
> > >
> =3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > ---
> webservices/axis2/trunk/java/modules/core/sr= c/org/apache/axis2/Constants.java
> (original)
> > > +++<= br>> webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/Cons= tants.java
> Mon Nov  7 01:12:27 2005
> > > @@ -195,6 +19= 5,9 @@
> > >        &nb= sp; public static final String ATTACHMENT_TEMP_DIR =3D
> "a= ttachmentDIR";
> > >      &n= bsp;   public static final String CACHE_ATTACHMENTS =3D
> "cacheAttachments";
> > >   &= nbsp;      public static final String FILE_SI= ZE_THRESHOLD =3D
> "sizeThreshold";
> > > +
= > > > +        // we need = to some times send the message as multipart/related,
> even if there is no MTOM stuff in the envelope.
> > > = +        public static final String= FORCE_MIME =3D "ForceMimeBoundary";
> > >  = ;    }
> > >
> > >  &= nbsp;   public static final String VALUE_TRUE =3D "true= ";
> > >
> > > Modified:
> webservices/axis2/tr= unk/java/modules/core/src/org/apache/axis2/context/MessageContextConstants.= java
> > > URL:
> http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/src= /org/apache/axis2/context/MessageContextConstants.java?rev=3D331245&r1= =3D331244&r2=3D331245&view=3Ddiff
> > >
> =3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D
> > > ---
> webservices/axis2/trunk/java/modules/core/sr= c/org/apache/axis2/context/MessageContextConstants.java
> (original)<= br>> > > +++
> webservices/axis2/trunk/java/modules/core/src= /org/apache/axis2/context/MessageContextConstants.java
> Mon Nov  7 01:12:27 2005
> > > @@ -21,5 +21,= 6 @@
> > >  public interface MessageContextConstants = {
> > >
> > >      //= this will contain the keys of all the properties that will be in
> the message context
> > >
> > >
> &g= t; >
> > > +
> > >
> > >  =     public static final String TRANSPORT_URL =3D "= TransportURL";
> > >
> > >  }
> > >
> > >
>= > > Modified:
> webservices/axis2/trunk/java/modules/core/src/= org/apache/axis2/transport/http/HTTPTransportUtils.java
> > > U= RL:
> http://svn.apac= he.org/viewcvs/webservices/axis2/trunk/java/modules/core/src/org/apache/axi= s2/transport/http/HTTPTransportUtils.java?rev=3D331245&r1=3D331244&= r2=3D331245&view=3Ddiff
> > >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > ---
> we= bservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http= /HTTPTransportUtils.java
> (original)
> > > +++
> webservices/axis2/trunk/j= ava/modules/core/src/org/apache/axis2/transport/http/HTTPTransportUtils.jav= a
> Mon Nov  7 01:12:27 2005
> > > @@ -452,12 += 452,13 @@
> > >         &nb= sp;            = msgContext.getProperty(
> > >
> Constants.Configuration.E= NABLE_MTOM));
> > >       &n= bsp;  }
> > > -      &n= bsp; boolean envelopeContainsOptimise =3D
> > > -
> HTTPTransportUtils.checkEnvelopeForOptimise(
&g= t; > > +
> > > +       = ; boolean forceMIME =3D
> Constants.VALUE_TRUE.equals(msgContext= .getProperty(Constants.Configuration.FORCE_MIME ));
> > > +        if(f= orceMIME) return true;
> > > +
> > > +  &= nbsp;     boolean envelopeContainsOptimise =3D
= > HTTPTransportUtils.checkEnvelopeForOptimise(
> > > &n= bsp;            = ;     msgContext.getEnvelope());
> > > -     = ;   boolean doMTOM =3D enableMTOM && envelopeContain= sOptimise;
> > > -       &nb= sp;msgContext.setDoingMTOM(doMTOM);
> > > -   &n= bsp;    return doMTOM;
> > > +        return enab= leMTOM && envelopeContainsOptimise;
> > >  &n= bsp;   }
> > >
> > >  &nbs= p;   public static boolean isDoingREST(MessageContext msgCon= text) {
> > >
> > >
> > >
> >
> >
> >= --
> > Davanum Srinivas : http= ://wso2.com/blogs/
> >
>
>
>
> --
> "May the SourcE be with u"
> http://webservices.apache.org/~thilina/
&= gt; http://thilinag.blogspot.com/
> http://www.b= loglines.com/blog/Thilina


--
Davanum Srinivas : http://wso2.com/blogs/



--
"May the SourcE be with u" =            
http://webservices.apache.or= g/~thilina/
http://thilina= g.blogspot.com/             = ;     http://www.bloglines.com/blog/Thilina     &nb= sp;        =20 ------=_Part_47675_24772529.1131425046762--