Return-Path: 
 <axis-dev-return-40392-apmail-ws-axis-dev-archive=ws.apache.org@ws.apache.org>
Delivered-To: apmail-ws-axis-dev-archive@www.apache.org
Received: (qmail 70935 invoked from network); 22 Nov 2005 14:48:08 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 22 Nov 2005 14:48:08 -0000
Received: (qmail 88506 invoked by uid 500); 22 Nov 2005 14:48:04 -0000
Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org
Received: (qmail 88426 invoked by uid 500); 22 Nov 2005 14:48:03 -0000
Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
list-help: <mailto:axis-dev-help@ws.apache.org>
list-unsubscribe: <mailto:axis-dev-unsubscribe@ws.apache.org>
List-Post: <mailto:axis-dev@ws.apache.org>
List-Id: <axis-dev.ws.apache.org>
Delivered-To: mailing list axis-dev@ws.apache.org
Received: (qmail 88380 invoked by uid 99); 22 Nov 2005 14:48:03 -0000
X-ASF-Spam-Status: No, hits=1.3 required=10.0
	tests=SPF_FAIL
X-Spam-Check-By: apache.org
Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2005 06:48:02 -0800
Received: from ajax.apache.org (ajax.apache.org [127.0.0.1])
	by ajax.apache.org (Postfix) with ESMTP id C5083592
	for <axis-dev@ws.apache.org>; Tue, 22 Nov 2005 15:47:41 +0100 (CET)
Message-ID: <1759066782.1132670861805.JavaMail.jira@ajax.apache.org>
Date: Tue, 22 Nov 2005 15:47:41 +0100 (CET)
From: "Juha Viskari (JIRA)" <axis-dev@ws.apache.org>
To: axis-dev@ws.apache.org
Subject: [jira] Created: (AXIS-2313) Overlapping element and attribute names
 rendered incorrectly from WSDL to Java
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Overlapping element and attribute names rendered incorrectly from WSDL to Java
------------------------------------------------------------------------------

         Key: AXIS-2313
         URL: http://issues.apache.org/jira/browse/AXIS-2313
     Project: Apache Axis
        Type: Bug
  Components: WSDL processing  
    Versions: 1.3    
 Environment: Windows XP
    Reporter: Juha Viskari


A sample WSDL:

<?xml version="1.0" encoding="UTF-8"?>
<wsdl:definitions targetNamespace="http://example.WebServices" xmlns="http://schemas.xmlsoap.org/wsdl/" xmlns:apachesoap="http://xml.apache.org/xml-soap" xmlns:impl="http://example.WebServices" xmlns:intf="http://example.WebServices" xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/" xmlns:tns1="http://sample.target.namespace" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:wsdlsoap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
 <wsdl:types>
  <schema targetNamespace="http://sample.target.namespace" xmlns="http://www.w3.org/2001/XMLSchema">
   <import namespace="http://schemas.xmlsoap.org/soap/encoding/"/>
   <complexType name="ProblematicType">
        <sequence>
	        <element name="duplicatename" type="unsignedLong"/>
        </sequence>
        <attribute name="duplicatename" type="unsignedLong" use="required"/>
   </complexType>
  </schema>
 </wsdl:types>

   <wsdl:message name="ProblematicType">
      <wsdl:part name="fault" type="tns1:ProblematicType"/>
   </wsdl:message>
   <wsdl:message name="getSomethingRequest"/>

   <wsdl:portType name="bugSample">
      <wsdl:operation name="getSomething">
         <wsdl:input message="impl:getSomethingRequest" name="getSomethingRequest"/>
         <wsdl:fault message="impl:ProblematicType" name="ProblematicType"/>
      </wsdl:operation>
   </wsdl:portType>

   <wsdl:binding name="sample.SoapBinding" type="impl:bugSample">
      <wsdlsoap:binding style="rpc" transport="http://schemas.xmlsoap.org/soap/http"/>
      <wsdl:operation name="getSomething">
         <wsdl:input name="getSomethingRequest">
            <wsdlsoap:body encodingStyle="http://schemas.xmlsoap.org/soap/encoding/" namespace="http://example.WebServices" use="encoded"/>
         </wsdl:input>
         <wsdl:fault name="ProblematicType">
            <wsdlsoap:fault encodingStyle="http://schemas.xmlsoap.org/soap/encoding/" name="ProblematicType" namespace="http://example.WebServices" use="encoded"/>
         </wsdl:fault>
      </wsdl:operation>
   </wsdl:binding>

   <wsdl:service name="bugSample">
      <wsdl:port binding="impl:sample.SoapBinding" name="bugSample.cfc">
         <wsdlsoap:address location="http://example.com/WebServices/sample"/>
      </wsdl:port>
   </wsdl:service>
</wsdl:definitions>

WSDL2Java + compilation of the generated Java code reports
    [javac] C:\...\gen-src\namespace\target\sample\ProblematicType.java:20: duplicatename is already defined in ProblematicType
    [javac]            org.apache.axis.types.UnsignedLong duplicatename) {
    [javac]                                               ^

The generated code looks like:

    public ProblematicType(
           org.apache.axis.types.UnsignedLong duplicatename,
           org.apache.axis.types.UnsignedLong duplicatename) {
        this.duplicatename = duplicatename;
        this.duplicatename = duplicatename;
    }

I found the following correction log:

tomj        2004/01/08 13:32:23
  Modified:    java/test/wsdl/clash clash.wsdl VerifyFilesTestCase.java
               java/src/org/apache/axis/wsdl/toJava JavaBeanWriter.java
  Log:
  Fix problem with names pointed out by Zhou Zhu [zhou.zhu@ericsson.com]
  Have the Bean Writer check the variable names for duplicate and
  append a number (starting with 2) on to the end of duplicates.

The referred correction made in axis/wsdl/toJava/JavaBeanWriter.java was clearly present in the sources, but this kind of a WSDL managed to reproduce the problem. I made a quick hack in writeFullConstructor() in my local version of JavaBeanWriter.java to check the names in the same manner as in the earlier submitted correction.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira