axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: [Axis2] OM Space handling
Date Sat, 27 Aug 2005 02:27:57 GMT
Let's do it Eran :)

-- dims

On 8/26/05, Eran Chinthaka <chinthaka@opensource.lk> wrote:
> Hi Dennis,
> See my comments below.
> 
> Dennis Sosnoski wrote:
> 
> > My point is that I don't think you should be getting whitespace
> > reported this way. Can you email me details on one of the cases where
> > this is causing a problem?
> 
> Will do it in the course of the day.
> 
> >
> > In any case, I don't think there's any need to use a special kind of
> > object for this. AFAIKS you should be able to just use an OMText
> > directly, since whitespace outside of the root element of the document
> > is not significant for XML-Signature and, as I understand it, that's
> > the only place where you'd have a problem using OMText.
> 
> Ahh, thats an interesting fact. I didn't know that, SPACEs outside the
> rrot element are not important. If thats the case, I think, we can use
> OMText for whitespaces. Myself and Dims have this suggestion .
> In the case of the SPACE event, if the last node was OMText (but not an
> optimised one, MTOM), we can append the current SPACE for that. Else
> only we have to create a new OMText.
> 
> If that way is correct, I can change the code in that way.
> 
> Regards,
> Chinthaka
> 
> >
> >  - Dennis
> >
> > Eran Chinthaka wrote:
> >
> >> Well, this is an issue when I'm running the XML conformance tests.
> >> Some of the tests fails due to this.
> >>
> >> Anyway, I think these whitespaces will become critical in security
> >> environment too. So I think we have no option but to support it.
> >>
> >> -- Chinthaka
> >>
> >> Dennis Sosnoski wrote:
> >>
> >>> I'd think you should only get the SPACE event if you're using
> >>> validation, since the API says it represents ignorable whitespace
> >>> and that's only defined by reference to a document grammar. Have you
> >>> seen SPACE occur in cases without validation?
> >>>
> >>>  - Dennis
> >>>
> >>> Eran Chinthaka wrote:
> >>>
> >>>> Hi all,
> >>>>
> >>>> I was trying to find out the problems we have with XML conformance
> >>>> tests. One of the problems I saw was that we do not handle the
> >>>> SPACE event from the parser.
> >>>> What I thought was to use the OMText for that too. But that makes
> >>>> the other cases complicated. Currently, OMText's parent should be
> >>>> an OMElement, but not an OMContainer, which is correct. SPACE can
> >>>> come under the OMDocument, but not spaces.
> >>>> So I thought of introducing OMSpace to handle spaces. But this adds
> >>>> upto the memory. IMO, spaces are important in the security case
> >>>> only (am I missing something ? ). If thats the case, adding another
> >>>> object, just to handle spaces is affecting the memory.
> >>>> I googled to check how others have handled this, but unfortunately,
> >>>> all the impls i found have just discarded that event. (I couldn't
> >>>> look in to XBIS)
> >>>>
> >>>> Comments and thoughts ... ??
> >>>>
> >>>> Chinthaka
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >
> 
> 


-- 
Davanum Srinivas : http://wso2.com/ - Oxygenating The Web Service Platform

Mime
View raw message