Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 26181 invoked from network); 18 Jul 2005 15:41:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Jul 2005 15:41:16 -0000 Received: (qmail 16861 invoked by uid 500); 18 Jul 2005 15:41:12 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 16830 invoked by uid 500); 18 Jul 2005 15:41:12 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 16817 invoked by uid 99); 18 Jul 2005 15:41:11 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2005 08:41:11 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of davanum@gmail.com designates 64.233.170.202 as permitted sender) Received: from [64.233.170.202] (HELO rproxy.gmail.com) (64.233.170.202) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2005 08:41:05 -0700 Received: by rproxy.gmail.com with SMTP id 1so545479rny for ; Mon, 18 Jul 2005 08:41:07 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=A0j74umcdwpqQBQjjq5pX1UJtsqbGBr4WnFbTrorvXyZKMtMAkKTNaJOd/55wx8pvJdhjneUAGOeszY8hMVeIw51xIyTXhors40Y8B2wk0aDwnmlAWcVn6DoUY2RqaJdL0GBHa6iEF1xUOoJTptMV8F+zTxJCgnxnJb98emjCXI= Received: by 10.38.196.20 with SMTP id t20mr1563081rnf; Mon, 18 Jul 2005 08:41:07 -0700 (PDT) Received: by 10.38.8.28 with HTTP; Mon, 18 Jul 2005 08:41:07 -0700 (PDT) Message-ID: <19e0530f050718084142b76733@mail.gmail.com> Date: Mon, 18 Jul 2005 11:41:07 -0400 From: Davanum Srinivas Reply-To: dims@apache.org To: axis-dev@ws.apache.org Subject: Re: [Axis2] MIME Content ID handling for MTOM Cc: Thilina Gunarathne In-Reply-To: <1121699572.14130.65.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <19e0530f050715080625dc6f91@mail.gmail.com> <19e0530f0507151959b6c95ba@mail.gmail.com> <19e0530f050718032729c227fe@mail.gmail.com> <1121699572.14130.65.camel@localhost.localdomain> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Sanjiva, On 7/18/05, Sanjiva Weerawarana wrote: > On Mon, 2005-07-18 at 06:27 -0400, Davanum Srinivas wrote: > > Thilina, > > > > i'd suggest you concentrate on cleaning up the code for MTOM and > > writing more test cases with actual assert statements while we > > research this a bit more. >=20 > You do agree with the principle of getting the faulty impl corrected, > right? if we determine that it is faulty. then yes. let's not change it for now. > > for example > > - there are so many while loops which don't check if there are any > > more characters in the stream > > - are u handling unsupposted media exception? are we throwing it. are > > we catching it? are we handling all the exceptions in the specs? are > > there test cases for it? > > - are we handling all the http status codes specified in mtom/xop specs= ? > > - why are we createing intermediate ByteArrayOutputstreams and putting > > things in them. what is going to happen if we get 1 GB attachment or > > 512 MB soap part? there should not be any intermediate storage > > especially of things that are likely to grow. >=20 > +1 for cleaning up the code. >=20 > > - was there any effort to at least architect the code so that we can > > add mime and SwA later when we get a chance? >=20 > A XOP message is supposed to be wire-compatible with SwA. Is that not > the case? >=20 > What did you mean by "mime"? typo i meant dime > > - Can we get rid of httptransportsender as we talked about earlier? > > and so on.... >=20 > Not directly MTOM related .. in progress but slow week this week because > Ajith, Chathura and Eran are all at AC Europe. >=20 > Sanjiva. >=20 >=20 >=20 --=20 Davanum Srinivas -http://blogs.cocoondev.org/dims/