axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinath Perera <hemap...@gmail.com>
Subject Re: [axis2] Code commentary
Date Mon, 11 Jul 2005 06:31:38 GMT
Hi Glen;

+1 for IDEA code reformat! We agree on 100 char lines as I recall,
Does the IDEA reformat can handle that too?

I agree about the lack of comments .. will spent some time for fix it:)

Thanks
Srinath

On 7/11/05, Glen Daniels <glen@thoughtcraft.com> wrote:
> Hi folks!
> 
> I'm re-ramping up on the current state of Axis2, and hoping to dive in
> for some substantive coding work in the next few days (some work on
> modules and looking into RPC/enc).  As I'm going through the code, I
> notice a few things:
> 
> * Formatting inconsistencies all over the place... can we run the whole
> codebase through IDEA's "reformat code" tool?  (+1 from me!)
> 
> * We decided on either 80 or 100 char lines back in December (seach the
> archives for "80 columns"), and yet there are a lot of lines > 120 chars.
> 
> * Lack of comments.  It is really important to have at least some notion
> of what each class is for, and ideally a good explanation, in the
> JavaDoc header for that class (ditto for methods).  Lots of our current
> classes/methods are missing any comments.
> 
> Can folks try to rectify these things as we continue to work in various
> places?
> 
> Thanks,
> --Glen
> 
> P.S.  I'm super-pleased at the speed and size so far!!  Nice job!
> 
>

Mime
View raw message