axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopalakrishnan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2-81) SOAP11FaultSubCodeImpl.checkParent(OMElement) has wrong if condition
Date Wed, 20 Jul 2005 09:28:48 GMT
    [ http://issues.apache.org/jira/browse/AXIS2-81?page=comments#action_12316212 ] 

Gopalakrishnan commented on AXIS2-81:
-------------------------------------

Well, actually there should not be any SOAP11FaultSubCodeImpl class because SOAP 1.1 doesn't
define any SubCode element for Fault. So the SOAP11FualtCodeImpl shouldn't allows us to set
a subcode. i.e SOAP11FualtCodeImpl.setSubCode() can throw an java.lang.UnsupportedOperationException.

Another approach is; since SOAP 1.1 allows us extend the basic fault codes with adding '.'
separated subcodes like Client.Authentication etc, we can allow SubCodes to be added (i.e
SOAP11FualtCodeImpl.setSubCode()  will work properly), but when we serialize the SOA11PfaultCodeImpl
object we can return it as <faultcode>Client.Authentication</faultCode>  where
the SOAP11FualtCodeImpl had value "Client" and a SOAP11FaultSubCodeImpl added to it with a
value "Authentication". What you think?

> SOAP11FaultSubCodeImpl.checkParent(OMElement) has wrong if condition
> --------------------------------------------------------------------
>
>          Key: AXIS2-81
>          URL: http://issues.apache.org/jira/browse/AXIS2-81
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: core
>     Versions: 0.9
>  Environment: all
>     Reporter: Gopalakrishnan

>
> The current code has a set of parenthesis missing, which makes a valid condition fail.
>  if (!(parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof SOAP11FaultCodeImpl))

> should have been
>  if (! ( (parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof SOAP11FaultCodeImpl)
) ) .
> Another enhancement suggestion is when the code has a subcode added, serialize() can
serialize it as 
> codeValue.subcodeValue.  This is how subcodes have to be represented in SOAP1.1, since
it doesn't define a <subcode> child element for <code> (check : http://www.w3.org/TR/2000/NOTE-SOAP-20000508/#_Toc478383510)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message