axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eran Chinthaka (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2-81) SOAP11FaultSubCodeImpl.checkParent(OMElement) has wrong if condition
Date Wed, 20 Jul 2005 09:50:48 GMT
    [ http://issues.apache.org/jira/browse/AXIS2-81?page=comments#action_12316213 ] 

Eran Chinthaka commented on AXIS2-81:
-------------------------------------

Remember ?? Our SOAP Programming model is SOAP 1.2 Handler authors, engine developer, etc.,
will write on SOAP 1.2 api, irrespective of whether the recd message is SOAP 1.1 or 1.2. 

The ""correct"" mapping will be done within the system transparent to the user. 

So argument of SOAP 1.1 doesn't have SUbCode is null and void.

> SOAP11FaultSubCodeImpl.checkParent(OMElement) has wrong if condition
> --------------------------------------------------------------------
>
>          Key: AXIS2-81
>          URL: http://issues.apache.org/jira/browse/AXIS2-81
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: core
>     Versions: 0.9
>  Environment: all
>     Reporter: Gopalakrishnan

>
> The current code has a set of parenthesis missing, which makes a valid condition fail.
>  if (!(parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof SOAP11FaultCodeImpl))

> should have been
>  if (! ( (parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof SOAP11FaultCodeImpl)
) ) .
> Another enhancement suggestion is when the code has a subcode added, serialize() can
serialize it as 
> codeValue.subcodeValue.  This is how subcodes have to be represented in SOAP1.1, since
it doesn't define a <subcode> child element for <code> (check : http://www.w3.org/TR/2000/NOTE-SOAP-20000508/#_Toc478383510)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message