axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjiva Weerawarana <sanj...@opensource.lk>
Subject Re: [axis2] Code commentary
Date Mon, 11 Jul 2005 09:51:41 GMT
+1 for 80 columns! Let's have that vote again .. I sense my side may win
this time ;-).

I hate not being able to open files in vi in my 80 column shell too.

Sanjiva.

On Mon, 2005-07-11 at 13:00 +0530, Venkat Reddy wrote:
> On 7/11/05, Eran Chinthaka <chinthaka@opensource.lk> wrote:
> > Hi,
> > 
> > >
> > > For those who use Eclipse, it is as simple as right-clicking on the
> > > package or class and select "Source >> Format". The Eclipse bilt-in
> > > template will be applied. I think we can agree on the eclipse defalut
> > > template (also exported and attached here) for code, which also agrees
> > > with standard Java code conventions.
> > 
> > I didn't see line length as 100 in the attached template. I think it was 80.
> 
> Why not not just follow the standard convention
> (http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313)?
> It will save time in having our own formatter, if we just follow the
> default language standards. (Whats the default IDEA template?).
> Ofcourse, unless we have a specific need to have 100 rather than 80.
> 
> > 
> > >
> > > btw, whats most popular IDE for Axis dev community? :-) I'm a big fan
> > > of Eclipse.
> > 
> > Popularity does not make sense and has zero information. Individual
> > convenience is what that matters ;).
> > 
> > Hope we will not gonna start the Eclipse vs Idea war here :).
> 
> Nope, its not say something is better, but I think its worth talking
> about unless you want to maintain top secrecy about your IDE :-) and
> we already talking about IDEA, isn't it?
> 
> > 
> > -- Chinthaka
> > 
> > >
> > > -venkat
> > >
> > >
> > >
> > > On 7/10/05, Eran Chinthaka <chinthaka@opensource.lk> wrote:
> > > > Hi Glen and all,
> > > >
> > > > >
> > > > > Hi folks!
> > > > >
> > > > > I'm re-ramping up on the current state of Axis2, and hoping to dive
in
> > > > > for some substantive coding work in the next few days (some work
on
> > > > > modules and looking into RPC/enc).  As I'm going through the code,
I
> > > > > notice a few things:
> > > > >
> > > > > * Formatting inconsistencies all over the place... can we run the
> > > whole
> > > > > codebase through IDEA's "reformat code" tool?  (+1 from me!)
> > > >
> > > > +1 from me too. If some one can setup his IDE and save the code template
> > > and
> > > > send to us, that will be easy to share the same code style. So for
> > > others we
> > > > can enforce that by asking to put that template in the {IDEA_HOME}
> > > > \config\codestyles folder.
> > > >
> > > > Sorry I can not volunteer to this as I'm bit uncertain about some coding
> > > > styles. But if some one lays down them here, I can help :).
> > > >
> > > > >
> > > > > * We decided on either 80 or 100 char lines back in December (seach
> > > the
> > > > > archives for "80 columns"), and yet there are a lot of lines >
120
> > > chars.
> > > > >
> > > > > * Lack of comments.  It is really important to have at least some
> > > notion
> > > > > of what each class is for, and ideally a good explanation, in the
> > > > > JavaDoc header for that class (ditto for methods).  Lots of our
> > > current
> > > > > classes/methods are missing any comments.
> > > >
> > > > Will do this. I also need some time to do it.
> > > >
> > > > Regards,
> > > > Chinthaka
> > > >
> > > > >
> > > > > Can folks try to rectify these things as we continue to work in
> > > various
> > > > > places?
> > > > >
> > > > > Thanks,
> > > > > --Glen
> > > > >
> > > > > P.S.  I'm super-pleased at the speed and size so far!!  Nice job!
> > > > >
> > > >
> > > >
> > > >
> > > >
> > 
> > 
> >
> 


Mime
View raw message