axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: cvs commit: ws-axis/java/src/org/apache/axis/message NodeImpl.java
Date Fri, 27 May 2005 17:29:07 GMT
Venkat,

did you reopen the BUG?

-- dims

On 27 May 2005 10:20:12 -0000, venkat@apache.org <venkat@apache.org> wrote:
> venkat      2005/05/27 03:20:12
> 
>   Modified:    java/src/org/apache/axis/message NodeImpl.java
>   Log:
>   seems my last commit didnt make it to server. So repeating it again.
> 
>   Removing the call setDirty(true) fix the DOM serialization failures in ant all-tests.
Ideally, dirty flag should not cause serialization differences. But for now, i have to remove
this to fix some of the ant all-tests failures.
> 
>   Revision  Changes    Path
>   1.14      +1 -6      ws-axis/java/src/org/apache/axis/message/NodeImpl.java
> 
>   Index: NodeImpl.java
>   ===================================================================
>   RCS file: /home/cvs/ws-axis/java/src/org/apache/axis/message/NodeImpl.java,v
>   retrieving revision 1.13
>   retrieving revision 1.14
>   diff -u -r1.13 -r1.14
>   --- NodeImpl.java     24 May 2005 03:55:24 -0000      1.13
>   +++ NodeImpl.java     27 May 2005 10:20:12 -0000      1.14
>   @@ -493,7 +493,6 @@
>            ((NodeImpl) newChild).detachNode();
>            children.add(newChild);
>            ((NodeImpl) newChild).parent = this;
>   -        setDirty(true);
>            return newChild;
>        }
> 
>   @@ -509,6 +508,7 @@
>         */
>        public Node removeChild(Node oldChild) throws DOMException {
>            if (removeNodeFromChildList((NodeImpl) oldChild)) {
>   +            setDirty(true);
>                return oldChild;
>            }
>            throw new DOMException(DOMException.NOT_FOUND_ERR,
>   @@ -526,7 +526,6 @@
>                    itr.remove();
>                }
>            }
>   -        setDirty(true);
>            return removed;
>        }
> 
>   @@ -561,7 +560,6 @@
>                position = 0;
>            }
>            children.add(position, newChild);
>   -        setDirty(true);
>            return newChild;
>        }
> 
>   @@ -597,7 +595,6 @@
>            }
>            children.remove(position);
>            children.add(position, newChild);
>   -        setDirty(true);
>            return oldChild;
>        }
> 
>   @@ -658,7 +655,6 @@
>        public void detachNode() {
>            if (parent != null) {
>                parent.removeChild(this);
>   -            parent.setDirty(true);
>                parent = null;
>            }
>        }
>   @@ -691,7 +687,6 @@
>        public void setValue(String value) {
>            if (this instanceof org.apache.axis.message.Text) {
>                setNodeValue(value);
>   -            setDirty(true);
>            } else if (children != null) {
>                if (children.size() != 1) {
>                    throw new IllegalStateException( "setValue() may not be called on
a non-Text node with more than one child." );
> 
> 
> 
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message