axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Shahi (JIRA)" <axis-...@ws.apache.org>
Subject [jira] Updated: (AXIS-2019) Bug in getElementsByTagNameNS() method of SOAPDocumentImpl class
Date Fri, 27 May 2005 09:27:00 GMT
     [ http://issues.apache.org/jira/browse/AXIS-2019?page=all ]

Ashutosh Shahi updated AXIS-2019:
---------------------------------

    Attachment: 2019.diff

Patch for the problem ... ran all-tests.
Ashutosh

> Bug in getElementsByTagNameNS()  method of SOAPDocumentImpl class
> -----------------------------------------------------------------
>
>          Key: AXIS-2019
>          URL: http://issues.apache.org/jira/browse/AXIS-2019
>      Project: Axis
>         Type: Bug
>   Components: SAAJ
>     Versions: beta-2
>     Reporter: Ashutosh Shahi
>  Attachments: 2019.diff
>
> I found a bug in getElementByTagName and getElementByTagNameNS methods of SOAPDocumentImpl
class. he header and body parts call the above methods of MessageElement, but the result is
never combined, we just have separate return statements for header and body parts. The result
from both of them be combined and then returned. Am posting the relevant code, the patch will
follow:
> if (soapPart != null) {
>                 SOAPEnvelope soapEnv =
>                     (org.apache.axis.message.SOAPEnvelope) soapPart
>                     .getEnvelope();
>                 SOAPHeader header =
>                     (org.apache.axis.message.SOAPHeader) soapEnv.getHeader();
>                 if (header != null) {
>                     return header.getElementsByTagName(localName);
>                 }
>                 SOAPBody body =
>                     (org.apache.axis.message.SOAPBody) soapEnv.getBody();
>                 if (body != null) {
>                     return body.getElementsByTagName(localName);
>                 }
>             }
>             return null; 
> We should combine the result of header and body in a NodeList and then return.
> Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message