axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: SAAJ 1.2 not implemented yet ?!?!
Date Fri, 10 Dec 2004 16:37:21 GMT
ABSOLUTELY!!!!!! +10000 form me.

-- dims


On Fri, 10 Dec 2004 11:21:37 -0500, Tom Jordahl <tomj@macromedia.com> wrote:
> +1 to running as many tests and getting our SAAJ 1.2 implementation as good
> as it can be.
> 
> Mark, we would love your help on this.
> 
> --
> Tom Jordahl
> Macromedia Server Development
> 
> 
> 
> > -----Original Message-----
> > From: Mark D. Hansen [mailto:m.hansen23@verizon.net]
> > Sent: Friday, December 10, 2004 11:07 AM
> > To: axis-dev@ws.apache.org; dims@apache.org
> > Subject: RE: SAAJ 1.2 not implemented yet ?!?!
> >
> > dims,
> >
> > I submitted the bug, along with a patch to NodeImpl.java, and added a
> > test to test.saaj.TestDOM.java.  See
> > http://nagoya.apache.org/jira/browse/AXIS-1713.
> >
> > Do you think that you can include this fix in Axis 1.2 Final?
> >
> > From poking around in there, it seems to me that SAAJ 1.2 is still
> > pretty buggy.  I'll fix more stuff as I have time.
> >
> > For the project I'm working on, SAAJ 1.2 is important.  Personally, I'd
> > like to see Axis 1.2 Final have a very solid SAAJ 1.2 implementation.  I
> > don't know if anybody else cares that much about it or not.  If some of
> > you developers tell me that it is important, I could try to find time to
> > apply some of the W3C DOM implementation tests to Axis 1.2RC2, clean up
> > SAAJ as much as possible, and submit it all as a big patch.  But maybe
> > it is not worth cleaning up Axis SAAJ that much because it is going to
> > be superceded by Axis 2??? Let me know if anyone considers it important
> > to continue improving SAAJ 1.2 in Axis 1.2x.
> >
> > -- Mark
> >
> > > -----Original Message-----
> > > From: Davanum Srinivas [mailto:davanum@gmail.com]
> > > Sent: Friday, December 03, 2004 2:54 PM
> > > To: axis-dev@ws.apache.org
> > > Subject: Re: SAAJ 1.2 not implemented yet ?!?!
> > >
> > >
> > > Mark,
> > >
> > > It should be just you right now poking into these...if you can run
> > > "ant clean all-tests" and get all the tests to pass, that should be
> > > good enough and i have other things i can test with.
> > >
> > > thanks,
> > > dims
> > >
> > >
> > > On Fri, 3 Dec 2004 14:35:17 -0500, Mark D. Hansen
> > > <m.hansen23@verizon.net> wrote:
> > > > OK - I am working on this and will post to JIRA when I have
> > > something.
> > > > It seems to be non-trivial and involves changes to several
> > > classes in
> > > > the org.apache.axis.message package.
> > > >
> > > > If any developers are working on major changes to classes in the
> > > > org.apache.axis.message package, please let me know.
> > > >
> > > > If any of you developers can give me a quick rundown of
> > > problems you are
> > > > aware of with the SAAJ implementation (specifically DOM interfaces
> > > > inherited via NodeImpl and MessageElement) please let me know.
> > > >
> > > > What is the best way to test this package to make sure my
> > > changes don't
> > > > break anything?
> > > >
> > > > -- Mark
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Davanum Srinivas [mailto:davanum@gmail.com]
> > > > > Sent: Wednesday, December 01, 2004 3:48 PM
> > > > > To: axis-dev@ws.apache.org
> > > > > Subject: Re: SAAJ 1.2 not implemented yet ?!?!
> > > > >
> > > > >
> > > > > I can tell u where to start...Start with a junit test case (say
> > > > > http://cvs.apache.org/viewcvs.cgi/*checkout*/ws-axis/java/test
> > > > > /saaj/TestText.java),
> > > > > then make changes to it which are similar to what you
> > > want to do (run
> > > > > a xsl on the dom Element? and/or exercise the
> > > getAttributeNode method
> > > > > itself) then see if you can come up with a patch (or)
> > > just open a jira
> > > > > bug report with just the test case itself.
> > > > >
> > > > > thanks,
> > > > > dims
> > > > >
> > > > >
> > > > > On Wed, 1 Dec 2004 14:12:58 -0500, Mark D. Hansen
> > > > > <m.hansen23@verizon.net> wrote:
> > > > > > I just wasted a day trying to figure out what was causing a
> > > > > Xalan NPE deep inside my Axis application.  Since I'm casting
> > > > > MessageElements to org.w3c.dom.Element all the time, I am
> > > > > supposing the SAAJ 1.2 is implemented.
> > > > > >
> > > > > > After posting for help to the Xalan mail list (and wasting
> > > > > the time of some good people who tried to help me), I decided
> > > > > to take a closer look at what was going on with
> > > > > MessageElement.  Digging into the source code, I find this:
> > > > > >
> > > > > >     /**
> > > > > >      * This unimplemented operation is meand to return an
> > > > > attribute as a node
> > > > > >      * @see org.w3c.dom.Element#getAttributeNode(String)
> > > > > >      * @param attrName
> > > > > >      * @return null, always.
> > > > > >      * @todo Fix this for SAAJ 1.2 Implementation. marked
> > > > > as deprecated to warn people
> > > > > >      * it is broken
> > > > > >      * @deprecated this is not implemented
> > > > > >      */
> > > > > >     public Attr getAttributeNode(String attrName) {
> > > > > >         return null;
> > > > > >     }
> > > > > >
> > > > > > So SAAJ 1.2 is no longer working!?!  I see that the method
> > > > > is marked as deprecated, but to have saved myself the lost
> > > > > day of work and aggrevation, I would have had to compile the
> > > > > src and actually pay attention to the deprecation warnings.
> > > > > >
> > > > > > Of course, I should have read the release-notes.html for
> > > > > RC2, so I go there afterward to see what else I missed.  The
> > > > > only thing about SAAJ that I find is this:
> > > > > >
> > > > > > (in bold) "This version has passed the JAX-RPC 1.1 and SAAJ
> > > > > 1.2 TCKs"
> > > > > >
> > > > > > I'm sure that is true, but kind of misleading given the
> > > > > state of the getAttributeNode(...) methods in MessageElement.
> > > > > >
> > > > > > I hate to flame like this, because I appreciate what a huge
> > > > > amount of work it is to keep Axis moving forward.  Also, I'd
> > > > > like to submit a patch to fix this stuff - but I don't
> > > > > understand the MessageElement class well enough to do that.
> > > > > So, I guess that I am just frustrated.  I'd like to keep
> > > > > using Axis, but stuff like this is really getting me down.
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Davanum Srinivas - http://webservices.apache.org/~dims/
> > > > >
> > > >
> > >
> > >
> > > --
> > > Davanum Srinivas - http://webservices.apache.org/~dims/
> > >
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message