axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davanum Srinivas (JIRA)" <axis-...@ws.apache.org>
Subject [jira] Commented: (AXIS-1419) bug in getElementsByTagName of MessageElement
Date Mon, 25 Oct 2004 15:27:45 GMT
     [ http://issues.apache.org/jira/browse/AXIS-1419?page=comments#action_54608 ]
     
Davanum Srinivas commented on AXIS-1419:
----------------------------------------

Ashu,

Please take a look at http://cvs.apache.org/viewcvs.cgi/xml-xerces/java/src/org/apache/xerces/dom/DeepNodeListImpl.java
(mentioned by jongjin)

-- dims

> bug in getElementsByTagName of MessageElement
> ---------------------------------------------
>
>          Key: AXIS-1419
>          URL: http://issues.apache.org/jira/browse/AXIS-1419
>      Project: Axis
>         Type: Bug
>   Components: SAAJ
>     Versions: 1.2 Beta
>     Reporter: nishant kumar
>     Assignee: Davanum Srinivas
>  Attachments: Test1419.java, patch_1419.txt
>
> there is bug in the following method of MessageElement
> public NodeList getElementsByTagName(String name) {
> .....
>   // add 2nd Generation
>   for(int i =0; i < children.size(); i++){
>     nodelist.addChild((MessageElement)children.get(i));
>   }
> ....
> }
> first of all why should all the children be blindly added to the nodelist without making
any checks for the name.
> secondly why does one think that all the children will be instance of MessageElement
that one has once again blindly casted the children into MessageElement

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message