axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: Closed: (AXIS-1598) Generated Java artifacts name for Schema Anonymous type
Date Mon, 18 Oct 2004 22:29:58 GMT
Ias,

Mission is not complete till the code is written :)

-- dims


On Mon, 18 Oct 2004 22:59:27 +0100, Ias <iasandcb@hotmail.com> wrote:
> I tried the WSDL with JWSDP 1.4 and found that it resolved the conflict by
> following 4.3.12 "Name Collisions" in JAX-RPC 1.1 spec. More detailedly,
> 
> QueryResourceProperties.java (Type) -> QueryResourceProperties_Type.java
> (adding _Type suffix)
> QueryResourceProperties.java (PortType) ->
> QueryResourceProperties_PortType.java (adding _PortType suffix)
> 
> In my opinion, we need to implement avoiding name collisions based on the
> spec.
> (Note that now Axis 1.2 and JWSDP 1.4 behaves the same in generating Java
> artifacts from anonymous XML types in terms of naming conventions.)
> 
> Thanks,
> 
> Ias
> 
> P.S. dims, mission completed? :-)
> 
> 
> 
> > -----Original Message-----
> > From: Jarek Gawor [mailto:gawor@mcs.anl.gov]
> > Sent: Monday, October 18, 2004 3:28 PM
> > To: axis-dev@ws.apache.org
> > Subject: RE: Closed: (AXIS-1598) Generated Java artifacts
> > name for Schema Anonymous type
> >
> > This is already breaking our code! The new code overwrites
> > the remote interface of the operation with the class
> > generated as the input for that operation with the same name.
> > For example try with WS-ResourceProperties wsdl
> > (http://docs.oasis-open.org/wsrf/2004/06/wsrf-WS-ResourcePrope
> > rties-1.2-draf
> > t-01.wsdl).
> >
> > I vote to reverse this change. I think it's kind of late in
> > the 1.2 release process to make such huge changes.
> >
> > Jarek
> >
> > > -----Original Message-----
> > > From: Tom Jordahl [mailto:tomj@macromedia.com]
> > > Sent: Friday, October 15, 2004 1:17 PM
> > > To: 'axis-dev@ws.apache.org'
> > > Subject: RE: Closed: (AXIS-1598) Generated Java artifacts name for
> > > Schema Anonymous type
> > >
> > >
> > >
> > > Glen, team,
> > >
> > > I think we are going to need another RC because of this change (at
> > > least!).
> > >
> > > RC2 here we come....
> > >
> > > I am *so* scared of this.  It's going to break so many
> > people.  Hey, I
> > > wonder if it will break my product.  I better go test.
> > >
> > > --
> > > Tom Jordahl
> > > Macromedia Server Development
> > >
> > > > -----Original Message-----
> > > > From: axis-dev@ws.apache.org [mailto:axis-dev@ws.apache.org]
> > > > Sent: Friday, October 15, 2004 12:51 PM
> > > > To: axis-dev@ws.apache.org
> > > > Subject: [jira] Closed: (AXIS-1598) Generated Java
> > > artifacts name for
> > > > Schema Anonymous type
> > > >
> > > > Message:
> > > >
> > > >    The following issue has been closed.
> > > >
> > > >    Resolver: Ias
> > > >        Date: Fri, 15 Oct 2004 9:50 AM
> > > >
> > > > All the patches applied. Thanks, Jongjin.
> > > >
> > >
> > ---------------------------------------------------------------------
> > > > View the issue:
> > > >   http://issues.apache.org/jira/browse/AXIS-1598
> > > >
> > > > Here is an overview of the issue:
> > > >
> > >
> > ---------------------------------------------------------------------
> > > >         Key: AXIS-1598
> > > >     Summary: Generated Java artifacts name for Schema
> > Anonymous type
> > > >        Type: Improvement
> > > >
> > > >      Status: Closed
> > > >    Priority: Major
> > > >  Resolution: FIXED
> > > >
> > > >     Project: Axis
> > > >  Components:
> > > >              WSDL processing
> > > >    Fix Fors:
> > > >              current (nightly)
> > > >    Versions:
> > > >              current (nightly)
> > > >
> > > >    Assignee: Ias
> > > >    Reporter: Jongjin Choi
> > > >
> > > >     Created: Sun, 10 Oct 2004 11:39 PM
> > > >     Updated: Fri, 15 Oct 2004 9:50 AM
> > > >
> > > > Description:
> > > > Dear all.
> > > >
> > > > In the current version of Axis, the generated java
> > > artifacts name for
> > > > schema anonymous type begins with underscore.
> > > >
> > > > For example, in the AddressBook.wsdl in the
> > > > ws-axis/java/test/wsdl/addrNoImplSEI directory,
> > > >
> > > >  <xsd:element name="Phone">
> > > >     <xsd:complexType>
> > > >        <xsd:all>
> > > >             <xsd:element name="areaCode" type="xsd:int"/>
> > > >             <xsd:element name="exchange" type="xsd:string"/>
> > > >             <xsd:element name="number" type="xsd:string/>
> > > >        </xsd:all>
> > > >     </xsd:complexType>
> > > >  </xsd:element>
> > > >
> > > > The generated Java artifact for the element's complex type is
> > > > '_phone.java'.
> > > >
> > > > This convention may confuse the user because it does not follow
> > > > general java naming rule. It would be better if the generated
> > > > arftifact name is 'Phone.java' instead of '_phone.java' in
> > > this case.
> > > >
> > > > The JSR-109 introduces the new QName scheme for anonymous type.
> > > > Currently Axis makes a Java name from the QName by
> > > replacing '>' with
> > > > '_'. I think that java name can be derived from the QName
> > by using
> > > > empty string instead of '_' and making the character
> > > following '>' as
> > > > upper case.
> > > >
> > > > For example, the QName and its derived java name should be
> > > like these:
> > > > QName --> java name
> > > >
> > > >  X:>root   --> Root
> > > >  X:>root>inside --> RootInside   ('I' is also upper case)
> > > >
> > > > If name collision occurs, it will be resolved in the
> > > > resolveNameClashes() method of JavaGeneratorFactory.
> > > >
> > > > It seems that the JAX-RPC 1.1 is not clear for this. But
> > the SUN's
> > > > JWSDP works the way I said.
> > > >
> > > > I have fixed this in my local axis copy and passed
> > > all-tests with some
> > > > modification for generated artifacts name to the test cases
> > > for wsdl
> > > > (ws-axis/java/test/wsdl/).
> > > >
> > > > I know that it will break existing application using
> > Axis. But the
> > > > change will provide the users with more friendly names,
> > > compatibility
> > > > with other JAX-RPC runtime and less confusion.
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > ---------------------------------------------------------------------
> > > > JIRA INFORMATION:
> > > > This message is automatically generated by JIRA.
> > > >
> > > > If you think it was sent incorrectly contact one of the
> > > administrators:
> > > >    http://issues.apache.org/jira/secure/Administrators.jspa
> > > >
> > > > If you want more information on JIRA, or have a bug to report see:
> > > >    http://www.atlassian.com/software/jira
> > >
> > >
> >
> >
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message