axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: Axis performance and MessageElement.equals()
Date Fri, 15 Oct 2004 12:24:52 GMT
Nishant,

Am confused....What's the point of having a cache of DocumentBuilders
if you don't release it back into the cache?

-- dims

On 15 Oct 2004 16:55:26 +0530, Nishant Kumar <nishant.kumar@itellix.com> wrote:
> hi,
> sorry, i meant we should NOT be releasing the documentbuilder in the
> finally clause. we can just discard the builder if there is any
> exception. kindly have a look at the attached patch. this suggestion is
> based on the latest from the cvs.
> 
> 
> bye for now,
> nishant
> 
> On Fri, 2004-10-15 at 15:40, Davanum Srinivas wrote:
> > Nishant,
> > check the latest CVS :)
> >
> > -- dims
> >
> >
> > On 15 Oct 2004 10:13:47 +0530, Nishant Kumar <nishant.kumar@itellix.com> wrote:
> > > hi Jongjin,
> > >         can you make a slight change to XMLUtils. I think we should be
> > > releasing the documentbuilder in the finally clause. May be, we can just
> > > discard the document builder if there is an exception. You can have a
> > > look at the attached patch.
> > >
> > >
> > > thanks,
> > > nishant
> > > On Thu, 2004-10-14 at 21:03, Davanum Srinivas wrote:
> > > > Jongjin,
> > > >
> > > > AXIS-1597 should be fixed now.
> > > >
> > > > -- dims
> > > >
> > > >
> > > > On Thu, 14 Oct 2004 16:23:24 +0900, Jongjin Choi <gunsnroz@hotmail.com>
wrote:
> > > > > Nishant,
> > > > >
> > > > > I reviewed your note at http://nishantkumar.com/notes/tuning/axis.html.
> > > > > I think the third point in your note, 'ThreadLocal for DocumentBuilder'
 is related to the jira issue AXIS-1597.
> > > > > In AXIS-1597, I mentioned another way to reuse the DocumentBuilder.
> > > > >
> > > > > Using this way, I think Axis can serve all threads with fewer number
of DocumentBuilder compared to per-thread model.
> > > > >
> > > > > What do you think about that?
> > > > >
> > > > >
> > > > >
> > > > > Jongjin/
> > > > >
> > > > > ----- Original Message -----
> > > > > From: "Nishant Kumar" <nishant.kumar@itellix.com>
> > > > > To: <axis-dev@ws.apache.org>
> > > > > Sent: Thursday, October 14, 2004 2:29 PM
> > > > > Subject: Re: Axis performance and MessageElement.equals()
> > > > >
> > > > > > hi,
> > > > > > this is exactly the second point i have mentioned at
> > > > > > http://nishantkumar.com/notes/tuning/axis.html.
> > > > > >
> > > > > > I have also suggested a simple solution for this which will
apply for
> > > > > > most of the situations.
> > > > > > this time i am attaching a patch for
> > > > > > src/org/apache/axis/message/NodeImpl.java and
> > > > > > src/org/apache/axis/message/MessageElement.java
> > > > > >
> > > > > > these two patches will solve the problem, most of the time.
this will
> > > > > > surely boost performance.
> > > > > > you can have look at these patches to find out what i mean by
most of the time.
> > > > > >
> > > > > > i will attach these patches in
> > > > > > http://issues.apache.org/jira/browse/AXIS-1497 too.
> > > > > >
> > > > > > thanks,
> > > > > > nishant
> > > > > >
> > > > > > On Thu, 2004-10-14 at 03:21, Steve Green wrote:
> > > > > > > Developers,
> > > > > > >
> > > > > > > I've been doing some performance profiling and I stumbled
into
> > > > > > > MessageElement.equals().  Is there any reason why the equals
method
> > > > > > > needs to compare strings?  Can it not just compare the
objects?
> > > > > > >
> > > > > > > The reason I ask is because of because of NodeImpl.  NodeImpl
keeps an
> > > > > > > ArrayList of children.  Many of the operations in NodeImpl
use
> > > > > > > ArrayList.indexOf() which calls equals().  Isn't it the
case that
> > > > > > > removeChild(), insertBefore(), etc... should be looking
for a specific
> > > > > > > object, not an object that looks the same?  While we're
at it, shouldn't
> > > > > > > removeChild() return after finding the child?  Currently,
it continues
> > > > > > > to search for more children that equals() the child to
remove.  The DOM
> > > > > > > documents are not clear on this.
> > > > > > >
> > > > > > > Thank you.
> > > > > > >
> > > > > > > ~S
> > > > > > >
> > > > > >
> > > >
> > >
> > >
> > >
> >
> 
> 
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message