axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jongjin Choi (JIRA)" <axis-...@ws.apache.org>
Subject [jira] Commented: (AXIS-1614) Name collision of generated code caused by AXIS-1598
Date Fri, 29 Oct 2004 05:18:34 GMT
     [ http://issues.apache.org/jira/browse/AXIS-1614?page=comments#action_54784 ]
     
Jongjin Choi commented on AXIS-1614:
------------------------------------

This is the patch.

cvs diff -u Namespaces.java 
Index: Namespaces.java
===================================================================
RCS file: /home/cvspublic/ws-axis/java/src/org/apache/axis/wsdl/toJava/Namespaces.java,v
retrieving revision 1.11
diff -u -r1.11 Namespaces.java
--- Namespaces.java	24 Oct 2004 19:12:56 -0000	1.11
+++ Namespaces.java	29 Oct 2004 05:06:49 -0000
@@ -257,7 +257,10 @@
         } else {
             v = (Vector)pkg2NamespacesMap.get(value);
         }
-        v.add(key);
+        // NOT need to add a input key(=namespace value) to v(=package vector);
+        if (!v.contains(key)) {
+            v.add(key);
+        }
         pkg2NamespacesMap.put(value, v);
          
         return super.put(key, value);

***** CVS exited normally with code 1 *****

> Name collision of generated code caused by AXIS-1598
> ----------------------------------------------------
>
>          Key: AXIS-1614
>          URL: http://issues.apache.org/jira/browse/AXIS-1614
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Jongjin Choi
>     Assignee: Ias
>  Attachments: JavaGeneratorFactory.diff.txt, SamePackageFix.zip, SymbolTable.diff.txt,
test.wsdl.diff.txt, wsrf-WS-ResourceProperties-1.2-draft-01-impl.wsdl
>
> After AXIS 1598 was applied, we met a naming problem that did not exist before.
> * Problem
> WSDL2Java can not process the wsdl which has the same name in portType, operation, complexType
and/or other stuff in it.
> * Solution
> The 4.3.12 of JAX-RPC 1.1 spec addressed this kind of naming collisions. This is partly
implemented in current Axis. 
> The attached patch makes it a little more compliant to JAX-RPC spec.
> This also solves the name collision problem of AXIS-1598.
> * Caution
> In current axis, Axis uses suffixes to resolve the name collision. For xsd:element and
wsdl:portType, the suffixes are:
> xsd:element -> _ElemType
> wsdl:PortType -> _Port
> But in JAX-RPC 1.1 spec, the suffixes are:
> xsd:element -> _Element
> wsdl:PortType -> _PortType
> I follow the way of JAX-RPC 1.1 in this patch. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message