axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From axis-...@ws.apache.org
Subject [jira] Commented: (AXIS-1501) [EWS, AXIS2] A proposal for xml-to-java name mapping in Axis and EWS (WSDL --> Java)
Date Sat, 21 Aug 2004 10:34:21 GMT
The following comment has been added to this issue:

     Author: Jongjin Choi
    Created: Sat, 21 Aug 2004 3:33 AM
       Body:
I made a patch to support jaxrpc-mapping in Axis when we start from WSDL.

These are the details for the patch:
(1) Single point to access contained element and attribute defined in shema type
   This might be a part of big picuture ,'separating WSDL processing and code/xml generation'.

   The contained element and attributes of complex type refered in serveral places in Axis
code using
   SchemaUtils.getContainedElementDeclarations() and SchemaUtils.getContainedAttribueTypes()
method.
   
   I refactored this and add new field to 'TypeEntry' class for these elements and attributes.
   I added new class 'ContainedEntry' which is parent class for the contained element and
attribute class.
   Also the class for contained element and attribute were addded.
   For contained element, existing 'ElemenetDecl' class is now derived from 'ContainedEntry'
class.
   For contained attribute, new class 'ContainedAttribute' is added. (is AttributeDecl better
name?)
   The 'TypeEntry' has two vectors, each holds the 'ElementDecl' and 'ContainedAttribute'
objects.

(2) Single point of javifying java names from wsdl names for java type and its fields.
   Especially, the JavaBeanWriter and JavaBeanHelperWriter access the contained element and
   attributes and to generate code for that. 
   Currently, the wsdl-to-java name mapping for field of the generated class 
   occurs here in Writer not JavaGenertorFactory.
   In my patch, all the wsdl-to-java name mapping for the generated class ant its fields 
   occurs in JavaGenerationFactory, and the JavaBeanWriter and JavaBeanHelperWriter use the
information
   through TypeEntry.
   The wsdl-to-java name mapping logic exists in toJava.Emitter which enables to hook the
default mapping when
   we have input jax-rpc mapping file.  

(3) Flag for generated classes in Type object in SymbolTable's typeTypeEntries
   It can be used for jax-rpc mapping generation in EWS.
   In o.a.axis.wsdl.symbolTable.Type, I added a boolean flag 'generated' which indicates that
   the java class for this Type is generated during code generation phase.
   
   The following is the pseudo code to generate the <java-xml-type-mapping> and its
child <variable mapping>
   using this patch. ('JaxRpcMappingBindingHelper' is a helper class that makes the JAXB object)
   
        Map typeMap = symbolTable.getTypeIndex();
        Set typeSet = typeMap.entrySet();
        for (Iterator iter = typeSet.iterator(); iter.hasNext();) {
            Map.Entry element = (Map.Entry) iter.next();
            QName qName = (QName) element.getKey();
            Type type = (Type) element.getValue();
            if (type.isGenerated()) {
                boolean isAnonymous = qName.getLocalPart().indexOf('>') >= 0;
                String qNameScope = type.isSimpleType() ? "simpleType" : "complexType";
                String className = type.getName();
                JavaXmlTypeMappingType javaType = JaxRpcMappingBindingHelper.createJavaXmlTypeMapping(className,

                        isAnonymous, qName, qNameScope);
                JaxRpcMappingBindingHelper.addJavaXmlTypeMapping(mapping, javaType);
                
                List varMappings = javaType.getVariableMapping();
                
                Vector elements = type.getContainedElements();
                if (elements != null) {
                    for (int i = 0; i < elements.size(); i++) {
                        ElementDecl elem = (ElementDecl) elements.get(i);
                        String xmlName = Utils.getLastLocalPart(elem.getQName().getLocalPart());
                        String javaName = elem.getName();
                        VariableMappingType varMapping = JaxRpcMappingBindingHelper.createVariableMappingElement(javaName,
Boolean.FALSE, xmlName);
                        varMappings.add(varMapping);
                    }
                }
                
                Vector attrs = type.getContainedAttributes();
                if (attrs != null) {
                    for (int i = 0; i < attrs.size(); i++) {
                        ContainedAttribute attr = (ContainedAttribute) attrs.get(i);
                        String xmlName = Utils.getLastLocalPart(attr.getQName().getLocalPart());
                        String javaName = attr.getName();
                        VariableMappingType varMapping = JaxRpcMappingBindingHelper.createVariableMappingElement(javaName,
Boolean.FALSE, xmlName);
                        varMappings.add(varMapping);
                    } 
                }
            }
        }
   
Thanks.


---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/AXIS-1501?page=comments#action_37370

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1501

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1501
    Summary: [EWS, AXIS2] A proposal for xml-to-java name mapping in Axis and EWS (WSDL -->
Java)
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             WSDL processing
   Versions:
             current (nightly)

   Assignee: 
   Reporter: Jongjin Choi

    Created: Mon, 9 Aug 2004 10:15 AM
    Updated: Sat, 21 Aug 2004 3:33 AM

Description:
Dear Axis developers.

This is a proposal for support standard jax-rpc mapping (especially <java-xml-type-mapping>)

and some related issues. In this proposal, I will address only to top-down case. 
(I did not arrange my thought in bottom-up case)

I'm not native english speaker so the sentence may not be fluent. Please be patient.

--------------------------------------------------------------------------------------------------------------------
1. Rationale
The JSR-109 specification requires jax-rpc mapping file for portable web services provider/requester
application archive.
It is a developer's role to write the jax-rpc mapping file but it is error-prone and tedious
to write a jax-rpc mapping file by hand.
it would be helpful if the JSR-109 implementation provides a facility that generates jax-rpc
mapping file automatically 
in both top-down (from WSDL) and bottom-up (from Java) cases.

EWS project made a big progess in implementing open-source JSR-109 implementation 
and we expect that other JCP standards(JSR-181, JAX-RPC 2.0) will be integrated with Axis

based on our experience on EWS.

With additional support of Axis for java-xml mapping, 
generating <java-xml-type-mapping> in EWS seems can be streamlined and
the probable code duplication between Axis and EWS will be minimized.

2. Top-down (from WSDL to Java) case
2-1. support for schema type (and nested types) and its java mapping 
org.apache.axis.wsdl.symbolTable package represents the entire wsdl model
and org.apache.axis.wsdl.toJava package do all code generation tasks for symbolTable's entries.

Each entry in symbolTable has its wsdl qname(name) and its corresponding java name 
and the writers in toJava package use this information when generating java code.

The mapping of wsdl name to java name is toJava.JavaGeneratorFactory's javifyNames(). 
The only lack in mapping is for the nested types in TypeEntry that is mapped to member of
generated JavaBeans.
This nested type and JavaBean's member name mapping is done in JavaBeanWriter and/or JavaBeanHelperWriter.

I suggest that all the wsdl/schema name to java name mapping should be done in one place 
(javifyNames() in JavaGeneratorFactory) 
and all other writers should generate java codes without additional xml to java name mapping.

To accomplish this, we need addtional members in TypeEntry class 
that represents element and attribute which is defined in the type definition in the schema.
We may also need the member for xml value for complexType 
which have simpleContents with extension or recstriction xsd simpleTypes.
These are corresponding to the @XmlElement, @XmlAttribute and @XmlValue in "8.9" in JAXB 2.0
early draft. 

These properties are already passed to newly created JavaBeanWriter/JavaBeanHelperWriter 
in current Axis source. 
(getBeanWriter() in JavaTypeWriter)

Also the TypeEntry class should have the flag that its corresponding java class should be
genrated or not. 

2-2. JavaBeanWriter / JavaBeanHelperWriter / JavaBeanFaultWriter / JavaDefinitionWriter and
some other writers
As pointed out in 2-1, if the TypeEntry has all the wsdl/xml-to-java mapping for members of
its generated JavaBean,
the other writers can use the information for its code generation without additional xml-to-java
name mapping 
and duplicate code between writers for naming mapping can be reduced.

2-3. EWS jax-rpc mapping generation
In EWS, the generation of <java-xml-type-mapping> and its child <variable-mapping>
can be simple.
We need to lookup all the Types in symbolTable (which is accessible by wsdl-to-Java emiiter
object) 
and check if it has generated java classes and , if it has, generate <java-xml-type-mapping>
for that class.

The other information needed in <java-xml-type-mapping> like the whether it is simple,
complex or anonymous type,
I think, can be acquired directly by TypeEntry.

In EWS, we need not to generate jax-rpc mapping if the wsdl-to-java emitter has input jax-rpc
mapping file.
If the input jax-rpc mapping provided, we may be able to apply the wsdl/xml-to-java name mapping

using JavaGeneratorFactory and/or toJava.Emitter's wsdl naming hook.

We may need to generate java-rpc mapping if the input jax-rpc mapping is not specified 
and the output jax-rpc mapping file is specifed.

3. Other portability issue
3-1. JavaBeanWriter's generated code
The code generated by JavaBeanWriter should be portable as in JSR-109. 
The generated code should not include axis class if possible.
Currently it use classes below org.apache.axis.* in its generated code for some case. 

3-2. JavaBeanFaultWriter / JavaDefinitionWriter's generated code
The Exception classes generated by JavaBeanFaultWriter and JavaDefinitionWriter 
should be portable, i.e. it should not extend AxisFault. 
It hurts the portability of the generated code from WSDL.

3-3. Integration of other technology to Axis
I think It will help Apache Beehive's JSR-181, future JAX-RPC 2.0 and JAXB 2.0 implementation
to be integrated to Axis.

-----------------------------------------------------------------------------------------------------------

Currently that's all. I hope we can make a consensus for this issue. 
I think that it is related to discussion topic in Axis 2.0 submit. (Tight binding between
WSDL processing and code generation).

Thanks for your interest


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message