axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <dava...@gmail.com>
Subject Re: RE: RE: RE: cvs commit: ws-axis/java/src/org/apache/axis/client AxisClien t.java Call.java
Date Tue, 29 Jun 2004 01:07:48 GMT
+1 to remove the flag.

On Mon, 28 Jun 2004 16:01:39 -0700, Glen Daniels <glen@thoughtcraft.com> wrote:
> 
> 
> Thanks for the pointer!  OK, did a little reading on this.
> 
> I think we should do one of two things here.  Either:
> 
> 1) Support SOAPConnectionFactory/SOAPConnection, but do NOT shut off MU
> handling.  Instead, we should be able to handle MU headers with global
> handlers, and if indeed there are MUs sent/returned that we don't
> understand, we should be faulting, as that is the correct thing to do.
> 
> OR
> 
> 2) Don't support SOAPConnectionFactory at all, since it's optional.
> 
> In other words, -1 to the change which put in the flag.  I really don't
> think we should put in an option to break the SOAP processing model.  If
> this is needed to pass some test, I would posit that the test is flawed.
> 
> I vote for option 1, which was status quo before the change in question.
> 
> --Glen
> 
> 
> 
> > -----Original Message-----
> > From: Davanum Srinivas [mailto:davanum@gmail.com]
> > Sent: Monday, June 28, 2004 3:43 PM
> > To: axis-dev@ws.apache.org
> > Cc: dims@apache.org
> > Subject: Re: RE: RE: cvs commit:
> > ws-axis/java/src/org/apache/axis/client AxisClien t.java Call.java
> >
> > http://cvs.apache.org/viewcvs.cgi/ws-axis/java/samples/jaxm/Ud
> > diPing.java?annotate=1.3
> >
> > On Mon, 28 Jun 2004 13:45:48 -0700, Glen Daniels
> > <glen@thoughtcraft.com> wrote:
> > >
> > >
> > > SAAJ doesn't have sending and receiving APIs, does it?  That's
> > > Axis/JAX-RPC....
> > >
> > > I really don't understand (no pun intended :)) this at all.
> >  Could you
> > > please give us a specific use case?
> > >
> > > --Glen
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Davanum Srinivas [mailto:davanum@gmail.com]
> > > > Sent: Monday, June 28, 2004 8:23 AM
> > > > To: Tom Jordahl
> > > > Cc: dims@apache.org; axis-dev@ws.apache.org
> > > > Subject: Re: RE: cvs commit:
> > > > ws-axis/java/src/org/apache/axis/client AxisClien t.java Call.java
> > > >
> > > > Tom,
> > > >
> > > > This is an internal flag for our SAAJ Impl use ONLY.
> > > > Basically when using SAAJ API to send and receive soap messages
> > > > there is no way to set up jax-rpc handlers to consume
> > mustunderstand
> > > > stuff on the response back from the server. So if the server
> > > > responds with a MU true flag and there is no handler to
> > process we
> > > > throw an exception.
> > > > this is to prevent that scenario.
> > > >
> > > > -- dims
> > > >
> > > > On Mon, 28 Jun 2004 10:25:38 -0400, Tom Jordahl
> > > > <tomj@macromedia.com> wrote:
> > > > >
> > > > > Dims,
> > > > >
> > > > > Could you make sure we have documentation for this?
> > > > >
> > > > > What is the default?  Mustunderstand should *always* be
> > true, right?
> > > > >
> > > > > I am confused why SAAJ would require this....
> > > > >
> > > > > --
> > > > > Tom Jordahl
> > > > > Macromedia Server Development
> > > > >
> > > > > -----Original Message-----
> > > > > From: dims@apache.org [mailto:dims@apache.org]
> > > > > Sent: Saturday, June 26, 2004 11:14 PM
> > > > > To: ws-axis-cvs@apache.org
> > > > > Subject: cvs commit: ws-axis/java/src/org/apache/axis/client
> > > > > AxisClient.java Call.java
> > > > >
> > > > > dims        2004/06/26 20:13:40
> > > > >
> > > > >   Modified:    java/src/org/apache/axis/client
> > > > AxisClient.java Call.java
> > > > >   Log:
> > > > >   SAAJ TCK Failure - Make the Must Understand Checker
> > configurable
> > > > >
> > > > >   Revision  Changes    Path
> > > > >   1.66      +6 -2
> > > > > ws-axis/java/src/org/apache/axis/client/AxisClient.java
> > > > >
> > > > >   Index: AxisClient.java
> > > > >
> > > >
> > ===================================================================
> > > > >   RCS file:
> > > > >
> > /home/cvs/ws-axis/java/src/org/apache/axis/client/AxisClient.java,v
> > > > >   retrieving revision 1.65
> > > > >   retrieving revision 1.66
> > > > >   diff -u -r1.65 -r1.66
> > > > >   --- AxisClient.java   20 Jun 2004 18:38:04 -0000      1.65
> > > > >   +++ AxisClient.java   27 Jun 2004 03:13:39 -0000      1.66
> > > > >   @@ -151,7 +151,9 @@
> > > > >
> > > > Messages.getMessage("noTransport00", hName));
> > > > >                    }
> > > > >
> > > > >   -                checker.invoke(msgContext);
> > > > >   +                if
> > > > (msgContext.isPropertyTrue(Call.CHECK_MUST_UNDERSTAND,
> > > > > true)) {
> > > > >   +                    checker.invoke(msgContext);
> > > > >   +                }
> > > > >
> > > > >                    /* Process the JAXRPC Handlers */
> > > > >                    invokeJAXRPCHandlers(msgContext);
> > > > >   @@ -171,7 +173,9 @@
> > > > >
> > > > >                    // Do SOAP Semantics checks here - this
> > > > needs to be
> > > > > a call to
> > > > >                    // a pluggable object/handler/something
> > > > >   -                checker.invoke(msgContext);
> > > > >   +                if
> > > > (msgContext.isPropertyTrue(Call.CHECK_MUST_UNDERSTAND,
> > > > > true)) {
> > > > >   +                    checker.invoke(msgContext);
> > > > >   +                }
> > > > >                }
> > > > >
> > > > >            } catch ( Exception e ) {
> > > > >
> > > > >   1.228     +6 -0
> > > > ws-axis/java/src/org/apache/axis/client/Call.java
> > > > >
> > > > >   Index: Call.java
> > > > >
> > > >
> > ===================================================================
> > > > >   RCS file:
> > > > /home/cvs/ws-axis/java/src/org/apache/axis/client/Call.java,v
> > > > >   retrieving revision 1.227
> > > > >   retrieving revision 1.228
> > > > >   diff -u -r1.227 -r1.228
> > > > >   --- Call.java 23 Jun 2004 19:16:52 -0000      1.227
> > > > >   +++ Call.java 27 Jun 2004 03:13:39 -0000      1.228
> > > > >   @@ -218,6 +218,12 @@
> > > > >        public static final String FAULT_ON_NO_RESPONSE =
> > > > > "call.FaultOnNoResponse";
> > > > >
> > > > >        /**
> > > > >   +     * If this property is true, code will enforce must
> > > > understand check
> > > > > on both
> > > > >   +     * the request and the response paths.
> > > > >   +     */
> > > > >   +    public static final String CHECK_MUST_UNDERSTAND =
> > > > > "call.CheckMustUnderstand";
> > > > >   +
> > > > >   +    /**
> > > > >         * Property for setting attachment format.
> > > > >         * Can be set to either DIME or MIME (default)
> > > > >         * @see #setProperty
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Davanum Srinivas - http://webservices.apache.org/~dims/
> > > >
> > > >
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
> >
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Mime
View raw message