axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Jordahl <t...@macromedia.com>
Subject RE: HTTPSender using HttpUrlConnection
Date Fri, 24 Oct 2003 18:33:10 GMT
Thanks Jongjin, this is great.

One bug I noticed on a quick look:

if (cookie2 != null) {
  connection.setRequestProperty(HTTPConstants.HEADER_COOKIE, cookie);
}

This should be HEADER_COOKIE2 in this code.

I can't tell how you changed the HTTPSender.java code for this class.  Is this a replacement
or a rewrite of the Sender class?  If so, if you could clean up the file with Apache copyright,
JavaDoc comments, logging, etc so we can replace the existing sender class that would be great.
 It looks like there is also a bunch of functionality in the current class that is not duplicated
in your new class.  Properties and the like that affect behavior.

Could you file this patch in the bug report with a description of what you changed?  That
way it won't get lost or forgotten.

--
Tom Jordahl
Macromedia Server Development

-----Original Message-----
From: gunsnroz [mailto:gunsnroz@hotmail.com] 
Sent: Friday, October 24, 2003 7:06 AM
To: axis-dev@ws.apache.org
Subject: HTTPSender using HttpUrlConnection

Hi.

I wrote a thread-safe HTTPSender using java.net.HttpUrlConnection 
for solving HTTP 1.1 persistence-connection and keep-alive 
problem which is addressed in
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16522.

I tested it and verify that keep-alive worked with .NET webservices.

I think that it will help pepple who need better HTTP support and can't use
Commons-Http for some reason.
Axis team, can you check this in Axis source tree???

-- Jongjin Choe/

Mime
View raw message