axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <stev...@iseran.com>
Subject Re: cvs commit: ws-axis/java/test/wsdl/interop4/groupH/simpleRPCenc SimpleRpcEncServiceTestCase.java
Date Mon, 29 Sep 2003 16:39:09 GMT
dims@apache.org wrote:
> dims        2003/09/29 07:03:09
> 
>   Modified:    java/test/wsdl/interop4/groupH/simpleRPCenc
>                         SimpleRpcEncServiceTestCase.java
>   Log:
>   Fix broken "ant clean all-tests" (caused by stevel's fix for enum keyword in java1.5)
>   http://marc.theaimsgroup.com/?l=axis-dev&m=106080171917669&w=2


oops.


I am very unhappy about enum becoming reserved...not because it isnt 
needed (just think how much easier code generation will be), but because 
it is a bit late; enum is so incredibly widely used. I think it is the 
only new keyword coming in Java1.5, no?

We also need to do something about the axis.enum package.

Regarding the enum patch I made -if it breaks things, should we roll it 
back? I am thinking particularly of whether Axis1.2 will break peoples' 
existing builds?

Trouble is, those same builds will break on java1.5, and it is always 
better to get your bugfix into your java component before sun ship, 
rather than after. Otherwise you get lots of email from people saying 
things like "Ant <javadoc> doesnt work on Java1.4.2", "Axis doesnt work 
on Java1.5, ....@

>   
>   Revision  Changes    Path
>   1.3       +1 -1      ws-axis/java/test/wsdl/interop4/groupH/simpleRPCenc/SimpleRpcEncServiceTestCase.java
>   
>   Index: SimpleRpcEncServiceTestCase.java
>   ===================================================================
>   RCS file: /home/cvs/ws-axis/java/test/wsdl/interop4/groupH/simpleRPCenc/SimpleRpcEncServiceTestCase.java,v
>   retrieving revision 1.2
>   retrieving revision 1.3
>   diff -u -r1.2 -r1.3
>   --- SimpleRpcEncServiceTestCase.java	8 Oct 2002 03:31:35 -0000	1.2
>   +++ SimpleRpcEncServiceTestCase.java	29 Sep 2003 14:03:09 -0000	1.3
>   @@ -242,7 +242,7 @@
>            ////////////////////////////////////////////////////////////////////////
>            // echoMultipleFaults4
>            int intParam = 66;
>   -        Enum enumParam = new Enum(1);
>   +        _enum enumParam = new _enum(1);
>            for (int i=1; i < 3; i++) {
>                try {
>                    binding.echoMultipleFaults4(i, intParam, enumParam);
>   
>   
>   



Mime
View raw message