axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gdani...@apache.org
Subject cvs commit: xml-axis/java/test/utils TestSrcContent.java
Date Sun, 24 Aug 2003 14:55:08 GMT
gdaniels    2003/08/24 07:55:08

  Modified:    java/test/utils TestSrcContent.java
  Log:
  Checking to make sure every log.[info|error|etc] call uses Messages.getMessage()
  isn't very friendly to this kind of pattern:
  
  String foo = Messages.getMessage("msg");
  log.error(foo);
  
  or even log.error(exception)
  
  So now we check for explicit strings (log.error("foo")) and fail on that.
  
  Revision  Changes    Path
  1.20      +3 -1      xml-axis/java/test/utils/TestSrcContent.java
  
  Index: TestSrcContent.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/test/utils/TestSrcContent.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- TestSrcContent.java	18 Jul 2003 07:16:23 -0000	1.19
  +++ TestSrcContent.java	24 Aug 2003 14:55:08 -0000	1.20
  @@ -189,9 +189,11 @@
                                          + "|wsdl\\1)"
                                          + "([a-zA-Z0-9_]+\\1)*"
                                          + "[^\\\\/]+\\.java",
  +                                       
                                          "log\\.(info|warn|error|fatal)"
                                          + "[ \\t]*\\("
  -                                       + "(?![ \\t]*Messages\\.getMessage)",
  +                                       + "(?=[ \\t]*\\\")",
  +                                       
                                          false),
   
               // Verify that exceptions are built with messages.
  
  
  

Mime
View raw message