axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roshan Weerasuriya" <ros...@opensource.lk>
Subject RE: C++ commits
Date Tue, 29 Jul 2003 05:04:58 GMT
hi tom,

I agree with you. Sorry for that. The reason is that when I try to commit around more than
2/3 files (a bunch of files) in a single commit I regularly get a CVS error. 

-----
error msg:
cvs [commit aborted]: end of file from server (consult above messages if any)
-----

The error doesn't appear when the no of files at a single commit is less (around 2 files).
So I had no option other than making several commits.

Roshan


On Mon, 28 Jul 2003 10:11:17 -0400, Tom Jordahl wrote
> For instance (not to pick on just you roshan):
> 
> "after introducing new Serializer interfaces IWrapperSoapSerializer 
> and IHandlerSoapSerializer"
> 
> was submitted in about 8+ commits.  
> 
> 1 would be better.
> 
> --
> Tom Jordahl
> Macromedia Server Development
> 
> -----Original Message-----
> From: Tom Jordahl [mailto:tomj@macromedia.com] 
> Sent: Monday, July 28, 2003 10:05 AM
> To: 'axis-dev@ws.apache.org'
> Subject: RE: C++ commits
> 
> Sanjiva,
> 
> What (I thought) I was seeing was *related* file changes, many times 
> with the same check in comment, being done in individual submits.  
> This is what I was hoping to get clumped in to a single check-in.
> 
> I have no problem with individual changes having different commits,
>  but at this early stage of the C++ project, it just seems that if 
> user X has a bunch of files to check in, they might as well do it 
> all together and detail what they did in a comprehensive comment.
> 
> --
> Tom Jordahl
> Macromedia Server Development
> 
> -----Original Message-----
> From: Sanjiva Weerawarana [mailto:sanjiva@watson.ibm.com] 
> Sent: Thursday, July 24, 2003 11:13 PM
> To: axis-dev@ws.apache.org
> Subject: Re: C++ commits
> 
> IMHO its better to have separate commits .. its easier for someone
> to monitor the commits ;-). How would you like if Dims kept doing
> monster commits?
> 
> Maybe its time to create axis-dev-c and axis-dev-j lists? Personally
> I'd rather keep the family together yet, but if its bothering people
> then we need to do something. Tom, would an additional mail filter
> solve the immediate problem for you?
> 
> Sanjiva.
> 
> ----- Original Message -----
> From: "Tom Jordahl" <tomj@macromedia.com>
> To: <axis-dev@ws.apache.org>
> Sent: Thursday, July 24, 2003 9:10 PM
> Subject: C++ commits
> 
> >
> > It would be super cool if you all could combine the (related) C++ code
> submissions in to a single commit. This make it easier for people to 
> either review (or not) your checkins.
> >
> > Sometimes its scary to see 50 unread messages in axis-dev.  :-)
> >
> > Thanks!
> > --
> > Tom Jordahl
> >
> >
> > -----Original Message-----
> > From: susantha@apache.org [mailto:susantha@apache.org]
> > Sent: Wednesday, July 23, 2003 11:52 PM
> > To: xml-axis-cvs@apache.org
> > Subject: cvs commit: xml-axis/c/src/wcg WSClass.cpp
> >
> >
> > susantha    2003/07/23 20:51:32
> >
> >   Modified:    c/src/wcg WSClass.cpp
> >   Log:
> >   now WCG can generate wrapper classes for web services that passes and
> returns complex types as well but not arrays
> >
> >   Revision  Changes    Path
> >   1.4       +2 -2      xml-axis/c/src/wcg/WSClass.cpp
> >
> >   Index: WSClass.cpp
> >   ===================================================================
> >   RCS file: /home/cvs/xml-axis/c/src/wcg/WSClass.cpp,v
> >   retrieving revision 1.3
> >   retrieving revision 1.4
> >   diff -u -r1.3 -r1.4
> >   --- WSClass.cpp 18 Jul 2003 13:31:44 -0000 1.3
> >   +++ WSClass.cpp 24 Jul 2003 03:51:31 -0000 1.4
> >   @@ -194,7 +194,7 @@
> >    file << "}" << endl;
> >    file << endl;
> >
> >   - file << "void" << m_Name << "::OnFault(IMessageData* pMsg)"
<< endl;
> >   + file << "void " << m_Name << "::OnFault(IMessageData* pMsg)"
<< endl;
> >    file << "{" << endl;
> >    file << "}" << endl;
> >    file << endl;
> >   @@ -216,7 +216,7 @@
> >    file << "\tstring method = name;" << endl;
> >    file << "\tISoapMethod* pMethod =
> mc->getSoapSerializer()->createSoapMethod();" << endl;
> >    file << "\tpMethod->setLocalName(method + \"Response\");" << endl;
> >   - file << "\tpMethod->setPrefix(\"" << "amp" << "\");"<<
endl; //amp -
> axis method prefix :)
> >   + file << "\tpMethod->setPrefix(" <<
> "mc->getSoapSerializer()->getNewNamespacePrefix()" << ");"<< endl;

> //amp - axis method prefix :)
> >    file << "\tpMethod->setUri(\"" << g_ClassNamespaces[m_AWSName]
<<
> "\");"<< endl; //http://www.opensource.lk will come from wsdd
> >    file << "\treturn SUCCESS;" << endl;
> >    file << "}" << endl;
> >
> >
> >


---------------
Lanka Software Foundation  (http://www.opensource.lk)
Promoting Open-Source Development in Sri Lanka.
---------------

Mime
View raw message