axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: cvs commit: xml-axis/java/src/org/apache/axis/transport/http AxisServlet.java
Date Sun, 02 Feb 2003 06:17:11 GMT

----- Original Message -----
From: "Glen Daniels" <gdaniels@macromedia.com>
To: <axis-dev@xml.apache.org>
Sent: Saturday, February 01, 2003 14:47
Subject: RE: cvs commit: xml-axis/java/src/org/apache/axis/transport/http
AxisServlet.java


>
> Actually, I don't think everything should be escaped all the time, really
I don't. :)
>
> I think there should be dumpToString() and dumpToSafeString(), i.e. two
different methods for two different bits of functionality, rather than an
overload with a flag.
>
> When not in an HTML/browser context (i.e. when debugging on the console,
for instance) it isn't much use to escape the string, IMHO.

I tell you why I reverted, and its this; half of dumpToString() was already
escaping XML...all the fault details were coming out escaped. So the
original code was already escaping in cases; the only case it wasnt escaping
was with the odd other bit, such as the fault string. Therefore there could
not have been any use of the method which absoutely relied on all the text
being unescaped. Therefore adding more escaping wasnt fundamentally changing
behaviour, just rounding it off.

-steve


Mime
View raw message