axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <d...@yahoo.com>
Subject Re: cvs commit: xml-axis/java/src/org/apache/axis/client Stub.java
Date Wed, 08 Jan 2003 17:06:46 GMT
Steve,

This is being exercised in the interop4/GroupG tests (indirectly). Which sends and receives
attachments in mime and dime. I does not fail for me as i have all the stuff needed for
attachments to work. I did not run "ant clean all-tests" without the mail*.jar. which would
have
caught the problem.

Thanks,
dims

--- Steve Loughran <steve_l@iseran.com> wrote:
> ta.
> 
> Question I have is 'how did this creep in'? The stub hasnt changed for a
> while...something else did. And Q#2 is 'why didnt we catch this'. Do we have
> any tests that just create junit stubs and call them?
> 
> 
> ----- Original Message -----
> From: <dims@apache.org>
> To: <xml-axis-cvs@apache.org>
> Sent: Wednesday, January 08, 2003 06:00
> Subject: cvs commit: xml-axis/java/src/org/apache/axis/client Stub.java
> 
> 
> > dims        2003/01/08 06:00:05
> >
> >   Modified:    java/src/org/apache/axis/client Stub.java
> >   Log:
> >   Fix problem noticed by steve -
> http://marc.theaimsgroup.com/?l=axis-dev&m=104200865925867&w=2
> >
> >   Revision  Changes    Path
> >   1.21      +5 -3      xml-axis/java/src/org/apache/axis/client/Stub.java
> >
> >   Index: Stub.java
> >   ===================================================================
> >   RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/client/Stub.java,v
> >   retrieving revision 1.20
> >   retrieving revision 1.21
> >   diff -u -r1.20 -r1.21
> >   --- Stub.java 2 Jan 2003 20:56:00 -0000 1.20
> >   +++ Stub.java 8 Jan 2003 14:00:04 -0000 1.21
> >   @@ -319,9 +319,11 @@
> >         */
> >        public void extractAttachments(Call call) {
> >            attachments.clear();
> >   -        Iterator iterator = call.getResponseMessage().getAttachments();
> >   -        while(iterator.hasNext()){
> >   -            attachments.add(iterator.next());
> >   +        if(call.getResponseMessage().countAttachments()>0) {
> >   +            Iterator iterator =
> call.getResponseMessage().getAttachments();
> >   +            while(iterator.hasNext()){
> >   +                attachments.add(iterator.next());
> >   +            }
> >            }
> >        }
> >
> >
> >
> >
> >
> 


=====
Davanum Srinivas - http://xml.apache.org/~dims/

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com

Mime
View raw message