Return-Path: Delivered-To: apmail-xml-axis-dev-archive@xml.apache.org Received: (qmail 1415 invoked by uid 500); 4 Oct 2002 15:25:17 -0000 Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@xml.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list axis-dev@xml.apache.org Received: (qmail 80179 invoked from network); 3 Oct 2002 15:37:48 -0000 Importance: Normal Sensitivity: To: axis-dev@xml.apache.org Subject: Re: VOTE : RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen Parser.java X-Mailer: Lotus Notes Release 5.0.5 September 22, 2000 From: "Rick Rineholt" X-MIMETrack: S/MIME Sign by Notes Client on Rick Rineholt/Raleigh/IBM(Release 5.0.5 |September 22, 2000) at 10/03/2002 11:37:08 AM, Serialize by Notes Client on Rick Rineholt/Raleigh/IBM(Release 5.0.5 |September 22, 2000) at 10/03/2002 11:37:08 AM, Serialize complete at 10/03/2002 11:37:08 AM, S/MIME Sign failed at 10/03/2002 11:37:08 AM: The cryptographic key was not found, Serialize by Router on D03NM120/03/M/IBM(Release 5.0.10 |March 22, 2002) at 10/03/2002 09:37:49 AM, Serialize complete at 10/03/2002 09:37:49 AM Message-ID: Date: Thu, 3 Oct 2002 11:37:40 -0400 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_alternative 0055CC2985256C47_=" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N This is a multipart message in MIME format. --=_alternative 0055CC2985256C47_= Content-Type: text/plain; charset="us-ascii" If I understand this change shouldn't a service that has a binding that can not be referenced at least generate some warning? Rick Rineholt "The truth is out there... All you need is a better search engine!" rineholt@us.ibm.com Please respond to axis-dev@xml.apache.org To: axis-dev@xml.apache.org cc: Subject: Re: VOTE : RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen Parser.java +1 from me. thanks, dims --- Glen Daniels wrote: > > All - this is a serious bug, and I think it merits the "we'll look like dorks if it's not fixed" > label. It changes nothing except that bindings which aren't explicitly referenced (i.e. SOAP > 1.1) are ignored when generating code. This means that we won't mistakenly generate mismatched > interfaces and implementations when a SOAP 1.2 binding references a "wrapped" PortType. > > I think we should vote to include this in 1.0. > > +1 from me. > > --Glen > > > -----Original Message----- > > From: gdaniels@apache.org [mailto:gdaniels@apache.org] > > Sent: Wednesday, October 02, 2002 1:24 PM > > To: xml-axis-cvs@apache.org > > Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen > > Parser.java > > > > > > gdaniels 2002/10/02 10:24:03 > > > > Modified: java/src/org/apache/axis/wsdl/gen Parser.java > > Log: > > If a bindingEntry is undefined, don't use it! > > > > This prevents problems with SOAP1.2 (or any other unknown) bindings. > > > > Fixes bug > > > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13209 > > > > (at least in that we generate compilable stuff now) > > > > Revision Changes Path > > 1.12 +1 -1 > > xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java > > > > Index: Parser.java > > =================================================================== > > RCS file: > > /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java,v > > retrieving revision 1.11 > > retrieving revision 1.12 > > diff -u -r1.11 -r1.12 > > --- Parser.java 24 Sep 2002 16:03:38 -0000 1.11 > > +++ Parser.java 2 Oct 2002 17:24:03 -0000 1.12 > > @@ -307,7 +307,7 @@ > > // If the binding is undefined, then > > we're parsing a Definition > > // that didn't contain a binding, > > merely a service that referred > > // to a non-existent binding. Don't > > bother writing it. > > - if (binding.isUndefined()) { > > + if (binding.isUndefined() || > > !bEntry.isReferenced()) { > > continue; > > } > > gen = genFactory.getGenerator(binding, > > symbolTable); > > > > > > > > ===== Davanum Srinivas - http://xml.apache.org/~dims/ __________________________________________________ Do you Yahoo!? New DSL Internet Access from SBC & Yahoo! http://sbc.yahoo.com --=_alternative 0055CC2985256C47_= Content-Type: text/html; charset="us-ascii"
If I understand this change shouldn't a service that has a binding that can not be referenced at least generate some warning?

Rick Rineholt
"The truth is out there...  All you need is a better search engine!"

rineholt@us.ibm.com

Please respond to axis-dev@xml.apache.org

To:        axis-dev@xml.apache.org
cc:        
Subject:        Re: VOTE : RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen  Parser.java



+1 from me.
thanks,
dims
--- Glen Daniels <gdaniels@macromedia.com> wrote:
>
> All - this is a serious bug, and I think it merits the "we'll look like dorks if it's not fixed"
> label.  It changes nothing except that bindings which aren't explicitly referenced (i.e. SOAP
> 1.1) are ignored when generating code.  This means that we won't mistakenly generate mismatched
> interfaces and implementations when a SOAP 1.2 binding references a "wrapped" PortType.
>
> I think we should vote to include this in 1.0.
>
> +1 from me.
>
> --Glen
>
> > -----Original Message-----
> > From: gdaniels@apache.org [mailto:gdaniels@apache.org]
> > Sent: Wednesday, October 02, 2002 1:24 PM
> > To: xml-axis-cvs@apache.org
> > Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen
> > Parser.java
> >
> >
> > gdaniels    2002/10/02 10:24:03
> >
> >   Modified:    java/src/org/apache/axis/wsdl/gen Parser.java
> >   Log:
> >   If a bindingEntry is undefined, don't use it!
> >
> >   This prevents problems with SOAP1.2 (or any other unknown) bindings.
> >
> >   Fixes bug
> >
> >   http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13209
> >
> >   (at least in that we generate compilable stuff now)
> >
> >   Revision  Changes    Path
> >   1.12      +1 -1
> > xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java
> >
> >   Index: Parser.java
> >   ===================================================================
> >   RCS file:
> > /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java,v
> >   retrieving revision 1.11
> >   retrieving revision 1.12
> >   diff -u -r1.11 -r1.12
> >   --- Parser.java        24 Sep 2002 16:03:38 -0000        1.11
> >   +++ Parser.java        2 Oct 2002 17:24:03 -0000        1.12
> >   @@ -307,7 +307,7 @@
> >                        // If the binding is undefined, then
> > we're parsing a Definition
> >                        // that didn't contain a binding,
> > merely a service that referred
> >                        // to a non-existent binding.  Don't
> > bother writing it.
> >   -                    if (binding.isUndefined()) {
> >   +                    if (binding.isUndefined() ||
> > !bEntry.isReferenced()) {
> >                            continue;
> >                        }
> >                        gen = genFactory.getGenerator(binding,
> > symbolTable);
> >
> >
> >
> >

=====
Davanum Srinivas - http://xml.apache.org/~dims/
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com

--=_alternative 0055CC2985256C47_=--