Return-Path: Delivered-To: apmail-xml-axis-dev-archive@xml.apache.org Received: (qmail 9088 invoked by uid 500); 18 Oct 2002 18:50:48 -0000 Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@xml.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list axis-dev@xml.apache.org Delivered-To: moderator for axis-dev@xml.apache.org Received: (qmail 55533 invoked from network); 18 Oct 2002 15:07:27 -0000 From: "Graham Hesselroth" To: Subject: BeanSerializer code-read, potential bug. Date: Fri, 18 Oct 2002 10:45:44 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4910.0300 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I was reading through the BeanSerializer class to try and get a better understanding of how to write my own custom serializers and noticed something that seems odd on line 316 of the current code. The relevant section looks like the following: 313: // Get the property descriptors for the super class 314: TypeDesc superTypeDesc = TypeDesc.getTypeDescForClass(superClass); 315: if (superTypeDesc != null) { 316: superPd = typeDesc.getPropertyDescriptors(); 317: } else { 318: superPd = BeanUtils.getPd(superClass, null); 319: } It seems like it would make more sense for line 316 to use the superTypeDesc when invoking getPropertyDescriptors() instead of typeDesc which refers to the class being serialized. Thanks, Graham