axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Daniels <gdani...@macromedia.com>
Subject VOTE : RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen Parser.java
Date Wed, 02 Oct 2002 17:30:40 GMT

All - this is a serious bug, and I think it merits the "we'll look like dorks if it's not
fixed" label.  It changes nothing except that bindings which aren't explicitly referenced
(i.e. SOAP 1.1) are ignored when generating code.  This means that we won't mistakenly generate
mismatched interfaces and implementations when a SOAP 1.2 binding references a "wrapped" PortType.

I think we should vote to include this in 1.0.

+1 from me.

--Glen

> -----Original Message-----
> From: gdaniels@apache.org [mailto:gdaniels@apache.org]
> Sent: Wednesday, October 02, 2002 1:24 PM
> To: xml-axis-cvs@apache.org
> Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen
> Parser.java
> 
> 
> gdaniels    2002/10/02 10:24:03
> 
>   Modified:    java/src/org/apache/axis/wsdl/gen Parser.java
>   Log:
>   If a bindingEntry is undefined, don't use it!
>   
>   This prevents problems with SOAP1.2 (or any other unknown) bindings.
>   
>   Fixes bug
>   
>   http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13209
>   
>   (at least in that we generate compilable stuff now)
>   
>   Revision  Changes    Path
>   1.12      +1 -1      
> xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java
>   
>   Index: Parser.java
>   ===================================================================
>   RCS file: 
> /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- Parser.java	24 Sep 2002 16:03:38 -0000	1.11
>   +++ Parser.java	2 Oct 2002 17:24:03 -0000	1.12
>   @@ -307,7 +307,7 @@
>                        // If the binding is undefined, then 
> we're parsing a Definition
>                        // that didn't contain a binding, 
> merely a service that referred
>                        // to a non-existent binding.  Don't 
> bother writing it.
>   -                    if (binding.isUndefined()) {
>   +                    if (binding.isUndefined() || 
> !bEntry.isReferenced()) {
>                            continue;
>                        }
>                        gen = genFactory.getGenerator(binding, 
> symbolTable);
>   
>   
>   
> 

Mime
View raw message