axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Jordahl <t...@macromedia.com>
Subject RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/toJava Jav aBindingWriter.java
Date Thu, 12 Sep 2002 21:00:11 GMT

Dims,

-1 on this change.
This code was added specifically to avoid overwriting the Impl file that may (will) exists
in many implementations.
This was discussed and agreed upon on the mailing list months and months ago.

I would agree with you that it might be NICE to have a switch and POSSIBLY not overwrite other
files, but that is another conversation.

--
Tom Jordahl
Macromedia


-----Original Message-----
From: dims@apache.org [mailto:dims@apache.org]
Sent: Thursday, September 12, 2002 3:39 PM
To: xml-axis-cvs@apache.org
Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/toJava
JavaBindingWriter.java


dims        2002/09/12 12:38:43

  Modified:    java/src/org/apache/axis/wsdl/toJava JavaBindingWriter.java
  Log:
  If we check for file's existence, we should do it for ALL files...AND we should have a command-line
flag to override this behavior. Right now this causes "all-tests" to fail on my machine. Due
to mismatched files.
  
  Revision  Changes    Path
  1.16      +2 -18     xml-axis/java/src/org/apache/axis/wsdl/toJava/JavaBindingWriter.java
  
  Index: JavaBindingWriter.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/toJava/JavaBindingWriter.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- JavaBindingWriter.java	9 Sep 2002 17:03:24 -0000	1.15
  +++ JavaBindingWriter.java	12 Sep 2002 19:38:43 -0000	1.16
  @@ -178,24 +178,8 @@
                   if (emitter.isSkeletonWanted()) {
                       skelWriter = getJavaSkelWriter(emitter, bEntry, symbolTable);
                   }
  -                String fileName = Utils.getJavaLocalName(bEntry.getName())
  -                        + "Impl.java";
  -                try {
  -                    if (Utils.fileExists(fileName,
  -                            binding.getQName().getNamespaceURI(),
  -                            emitter.getNamespaces())) {
  -                        System.out.println(Messages.getMessage(
  -                                "wontOverwrite", fileName));
  -                    }
  -                    else {
  -                        implWriter = getJavaImplWriter(
  -                                emitter, bEntry, symbolTable);
  -                    }
  -                }
  -                catch (IOException ioe) {
  -                    System.err.println(
  -                            Messages.getMessage("fileExistError00", fileName));
  -                }
  +                implWriter = getJavaImplWriter(
  +                        emitter, bEntry, symbolTable);
               }
           }
   }
  
  
  

Mime
View raw message