axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsi...@us.ibm.com
Subject RE: cvs commit: xml-axis/java/src/org/apache/axis/client Call.jav a
Date Mon, 05 Aug 2002 14:34:29 GMT
Starting figuring out what I was missing on my way to work this morning... 
amazing what a good nights sleep and a few moments with my head out of the 
sand will do!

So, I guess I'll get started with some pounding on Sun's front door :-)

Seriously, thanks for the pointer, I went back and read the javadoc.  And 
I have bad news :-]

We need to yank the method.  It simply doesn't belong at this level (it's 
high level config of Axis and networking runtime):
- the *only* Handler you have is for 'local' transport.  You folks are 
*test* driven (am I repeating myself? :-)
- it's simply the *wrong* thing to do in a managed environment.
- you are hiding config details under the covers.  If I were a user 
'using' AXIS and trying to debug (managed or unmanaged), this internal 
behavior with system-wide side effects would drive me *nuts*.

Do you (a) NEED the local transport handler, and (b) in a secure runtime 
environ, do you want it?  Depending upon the answers to those questions, I 
think the right answer is to:
- document internal handlers & how to use (set system property...)
- fix the tests to set 'local' transport handler on the command line,


*******************************************
Richard A. Sitze
IBM WebSphere WebServices Development




Glen Daniels <gdaniels@macromedia.com>
08/05/2002 12:23 AM
Please respond to axis-dev
 
        To:     "'axis-dev@xml.apache.org'" <axis-dev@xml.apache.org>
        cc: 
        Subject:        RE: cvs commit: xml-axis/java/src/org/apache/axis/client Call.jav
      a

 



Hm - you didn't go read the javadoc for the URL class, did you. :)

The way the URL class figures out what a valid protocol string looks like 
is by looking in a list of "transport packages".  This list comes from a 
system property, and the URL code is not going to change.  Therefore if 
you want new protocols like "local:" and "tcp:" to work, you'd better set 
that property.

In other words, what we gain is that everything works instead of breaking. 
 We don't want it scoped to our class, we want to set the system property. 
 In a managed environment this should probably (unfortunately) happen at 
deployment time in some container-specific way.

--Glen

> -----Original Message-----
> From: rsitze@us.ibm.com [mailto:rsitze@us.ibm.com]
> Sent: Sunday, August 04, 2002 7:12 PM
> To: axis-dev@xml.apache.org
> Subject: Re: cvs commit: xml-axis/java/src/org/apache/axis/client
> Call.java
> 
> 
> Glen, I didn't understand your brief explanation as to how 
> this works, or 
> why...  would you please go into more detail? 
> TRANSPORT_PROPERTY is ONLY 
> used in that one function, and ONLY the first time through... 
> so what do 
> we gain with the write-back? 
> 
> Worst case, can we use the AxisProperties.setProperty instead of the 
> System??  This will at least keep the write-back in scope to 
> the current 
> execution environment, and won't affect other environs (i.e. 
> web-apps).
> 
> <ras>
> 
> *******************************************
> Richard A. Sitze
> IBM WebSphere WebServices Development
> 
> 
> 
> 
> gdaniels@apache.org
> 08/04/2002 07:31 AM
> Please respond to axis-dev
> 
>         To:     xml-axis-cvs@apache.org
>         cc: 
>         Subject:        cvs commit: 
> xml-axis/java/src/org/apache/axis/client Call.java
> 
> 
> 
> 
> gdaniels    2002/08/04 05:31:01
> 
>   Modified:    java/src/org/apache/axis/transport/local 
> LocalSender.java
>                java/src/org/apache/axis/client Call.java
>   Log:
>   Replace code to deal with custom protocol types, and add code to
>   throw any Exception occurring during URL creation in the 
> LocalSender's
>   invoke().
> 
>   Revision  Changes    Path
>   1.37      +1 -0 
> xml-axis/java/src/org/apache/axis/transport/local/LocalSender.java
> 
>   Index: LocalSender.java
>   ===================================================================
>   RCS file: 
> /home/cvs/xml-axis/java/src/org/apache/axis/transport/local/Lo
> calSender.java,v
>   retrieving revision 1.36
>   retrieving revision 1.37
>   diff -u -r1.36 -r1.37
>   --- LocalSender.java           3 Jul 2002 17:50:33 -0000 1.36
>   +++ LocalSender.java           4 Aug 2002 12:31:01 -0000 1.37
>   @@ -145,6 +145,7 @@
>                    // This enables "local:///AdminService" 
> and the like to 
> work.
>                    serverContext.setTargetService(file);
>                } catch (Exception e) {
>   +                throw AxisFault.makeFault(e);
>                }
>            }
> 
> 
> 
> 
>   1.167     +8 -11 
> xml-axis/java/src/org/apache/axis/client/Call.java
> 
>   Index: Call.java
>   ===================================================================
>   RCS file: 
> /home/cvs/xml-axis/java/src/org/apache/axis/client/Call.java,v
>   retrieving revision 1.166
>   retrieving revision 1.167
>   diff -u -r1.166 -r1.167
>   --- Call.java          4 Aug 2002 03:23:10 -0000               1.166
>   +++ Call.java          4 Aug 2002 12:31:01 -0000               1.167
>   @@ -1459,17 +1459,14 @@
> 
>            transportPackages.add(packageName);
> 
>   -        // the following isn't safe/secure, and it's not 
> clear that 
> it's necessary.
>   -        // particularly in light of the AxisProperties model.
>   -//
>   -//        StringBuffer currentPackages = new StringBuffer();
>   -//        for (Iterator i = transportPackages.iterator(); 
> i.hasNext();) 
> {
>   -//            String thisPackage = (String) i.next();
>   -//            currentPackages.append(thisPackage);
>   -//            currentPackages.append('|');
>   -//        }
>   -//
>   -//        System.setProperty(TRANSPORT_PROPERTY, 
> currentPackages.toString());
>   +        StringBuffer currentPackages = new StringBuffer();
>   +        for (Iterator i = transportPackages.iterator(); 
> i.hasNext();) {
>   +            String thisPackage = (String) i.next();
>   +            currentPackages.append(thisPackage);
>   +            currentPackages.append('|');
>   +        }
>   +
>   +        System.setProperty(TRANSPORT_PROPERTY, 
> currentPackages.toString());
>        }
> 
>        /**
> 
> 
> 
> 
> 



Mime
View raw message