axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bu...@us.ibm.com
Subject RE: cvs commit: xml-axis/java/test/wsdl/ram RamServiceTestCase.ja va RamSoapBindingImpl.java
Date Mon, 29 Jul 2002 16:07:34 GMT
These are only tests, and we will ALWAYS have log4j during the tests,
right?  So I don't think it's a problem.

HOWEVER, if you know how to do what I did without using log4j, we should
probably do it that way.  (I'm just a logging novice who was sick of seeing
all that garbage.)

Russell Butek
butek@us.ibm.com


Tom Jordahl <tomj@macromedia.com> on 07/29/2002 10:51:40 AM

Please respond to axis-dev@xml.apache.org

To:    "'axis-dev@xml.apache.org'" <axis-dev@xml.apache.org>
cc:
Subject:    RE: cvs commit: xml-axis/java/test/wsdl/ram RamServiceTestCase.
       ja   va RamSoapBindingImpl.java




Russell,

Did you really want to use log4J APIs directly?

--
Tom Jordahl


-----Original Message-----
From: butek@apache.org [mailto:butek@apache.org]
Sent: Thursday, July 25, 2002 12:14 PM
To: xml-axis-cvs@apache.org
Subject: cvs commit: xml-axis/java/test/wsdl/ram RamServiceTestCase.java
RamSoapBindingImpl.java


butek       2002/07/25 09:14:12

  Modified:    java/test/wsdl/addrNoImplSEI AddressBookTestCase.java
                        Main.java
               java/test/wsdl/datatypes DataTypesTestCase.java
               java/test/wsdl/extensibility
                        ExtensibilityQueryBindingImpl.java
                        ExtensibilityQueryTestCase.java
               java/test/wsdl/multiref MultiRefTestCase.java
               java/test/wsdl/nested Nested2ServiceTestCase.java
               java/test/wsdl/ram RamServiceTestCase.java
                        RamSoapBindingImpl.java
  Log:
  Since we all agreed that the tests should only generate info on errors,
  I've
  removed some of the extra stuff from the tests:
  - some places getting rid of System.err.println/System.out.println
  - some places replacing them with assertTrue
  - test/wsdl/addrNoImplSEI/Main took a bit more effort
      - Removed all the System.err.printlns
      - Removed the try blocks which kept exceptions from propagating out.
        (this test could NEVER fail!)
      - The catch block check - "if (e.detail instanceof
      IllegalArgumentException)"
         was wrong.  AxisFaults coming across the wire don't have e.detail
         initialized.  (Question:  should they?)
      - Set the level on the logger to FATAL for the duration of this test,
        effectively turning off logging so we don't see the
        IllegalArgumentException.

  Revision  Changes    Path
  1.7       +7 -9      xml-
  axis/java/test/wsdl/addrNoImplSEI/AddressBookTestCase.java

  Index: AddressBookTestCase.java
  ===================================================================
  RCS file: /home/cvs/xml-
  axis/java/test/wsdl/addrNoImplSEI/AddressBookTestCase.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- AddressBookTestCase.java      3 Jul 2002 18:47:09 -0000     1.6
  +++ AddressBookTestCase.java      25 Jul 2002 16:14:12 -0000    1.7
  @@ -58,15 +58,13 @@
   import junit.framework.TestCase;
   import org.apache.axis.AxisFault;

  -import org.apache.axis.components.logger.LogFactory;
  -import org.apache.commons.logging.Log;
  +import org.apache.log4j.Level;
  +import org.apache.log4j.Logger;

Mime
View raw message