axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <>
Subject RE: code contribution
Date Wed, 10 Jul 2002 11:53:45 GMT

Well, as I see it, there is no need to further modularize HTTPSender.
The additional code can be inserted directly into HTTPSender. This can be
done in a pretty easy way, so the existing code will not be messed up,
only additional functionality is added. 

As I wrote Digest authentication needs in most cases two requests to 
be sent, and this can be solved only in HTTPSender (I guess). 

The alias support could be further modularized, but in this case, one
(or more) request parameter has to be sent to the SocketFactory. :(

The code I sent you previously is up to date, and can replace HTTPSender
as a whole, the changes are marked with comments. Only the contant values
have to be added in HTTPConstants. Of course it should be overviewed against
possible errors, but I guess at this time no further restructuring is
needed to add this code. 
The Digest authentication can be further improved later. 

Here I send you the code once more. 

 Br, Geza

P.S. Please CC the response to my address too, and if you have other ideas 
please write me. 

> Geza,
> Can you come up with ideas on how to modularize HTTPSender 
> such that you code can be easily
> plugged in. Please post it directly to axis-dev mailing list.
> Thanks,
> dims
> --- wrote:
> > Hi, 
> > 
> >  So I see Beta 3 is out. Very good ! As you said, I'm writing 
> > you again. I looked over the code once more. My opinion is about
> > the same as yesterday: 
> > 
> >  - Digest authentication belongs to this code for several reasons:
> > there need to be two requests (in some cases) - one for obtaining
> > cnonce, nonce, qop and other values from server to make the digest
> > and the other one to send the request with Digest 
> authentication info.
> > This logic I guess belongs to HTTPSender. And of course 
> HTTP authentication
> > at this point has nothing to do with socket creation. So I believe
> > Basic and Digest authentication go together. :)
> > 
> >  - Alias support could be separated in a custom SocketFactory, and
> > I pretty much like this idea, but how can we pass request 
> parameters (like
> > alias) to the socketfactory ? 
> > 
> >  And if you see that I misunderstood your letter, please 
> ignore the above,
> > and write me some more details. :)
> > 
> > 
> >  Br, Geza
> =====
> Davanum Srinivas -
> __________________________________________________
> Do You Yahoo!?
> Sign up for SBC Yahoo! Dial - First Month Free

View raw message