axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 10479] New: - should not include log4j.properties in axis.jar
Date Thu, 04 Jul 2002 12:02:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10479>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10479

should not include log4j.properties in axis.jar

           Summary: should not include log4j.properties in axis.jar
           Product: Axis
           Version: current (nightly)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Basic Architecture
        AssignedTo: axis-dev@xml.apache.org
        ReportedBy: Brian.Ewins@btinternet.com


The current build.xml copies log4j.properties into the axis jar. This can cause
difficulties for users (see eg
http://marc.theaimsgroup.com/?l=axis-user&m=102570398615206&w=2 )

- if the user bundles their own log4j.properties and axis.jar in a webapp, the
axis.jar one may 'win', surprising them.
- the default setup, FileAppender to axis.log, is often not desirable (eg for
unattended use a RollingFileAppender would be better), so the user will often
want to override the supplied log4j.properties.
- if a developer A removes log4j.properties from axis.jar in order to work
around the issue, developer B, upgrading axis a month later, will inadvertently
be adding the file back in, with unpredictable results.

I'm suggesting that this code in build.xml:
    <!-- in compile target -->
    <jar jarfile="${build.lib}/${name}.jar" basedir="${build.dest}" >
      <include name="org/**" />
      <include name="log4j.properties"/>
      <include name="simplelog.properties"/>
    </jar>

should just be changed to:
    <!-- in compile target -->
    <jar jarfile="${build.lib}/${name}.jar" basedir="${build.dest}" >
      <include name="org/**" />
    </jar>

    <!-- then later in the 'dist' target -->
    <!-- each copy should obviously be inserted after the appropriate 'mkdir' -->
    <copy file="${build.dest}/log4j.properties" todir="${dist.dir}"/>
    <copy file="${build.dest}/simplelog.properties" todir="${dist.dir}"/>
    <copy file="${build.dest}/log4j.properties"
todir="${dist.dir}/webapps/axis/WEB-INF/classes"/>
    <copy file="${build.dest}/simplelog.properties"
todir="${dist.dir}/webapps/axis/WEB-INF/classes"/>

this makes the log4j and simplelog properties available in the distro, in the
right place for the webapp. They're also copied to the top level of the
distribution so they get picked up in the classpath when executing the samples
as described in the documentation (install guide steps 6 and 7 add the axis
install dir to the classpath). Hopefully this minimises the user-visible changes
while making it easier to change the logging.

NB There will probably be changes required in other targets not involved in
producing the distribution (eg the one that builds the test .war?)

Mime
View raw message