Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@xml.apache.org
Message-ID: 
 <CB1FF0A474AEA84EA0206D5B05F6A4CB019403F3@S1001EXM02.macromedia.com>
From: Glen Daniels <gdaniels@macromedia.com>
To: "'axis-dev@xml.apache.org'" <axis-dev@xml.apache.org>
Subject: RE: Removed NLS from enter/exit log.debug
Date: Thu, 9 May 2002 14:51:38 -0400 
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"


Cool by me.  +1.

> -----Original Message-----
> From: Richard Sitze [mailto:rsitze@us.ibm.com]
> Sent: Thursday, May 09, 2002 2:43 PM
> To: axis-dev@xml.apache.org
> Subject: Removed NLS from enter/exit log.debug
> 
> 
> Russell is wrong, at least for our current project :-)
> I'm holding of on making across the board changes to 
> log.debug, and only
> touching the entry/exit.
> We can open the discussion on the remaining debug messages 
> until a later
> date.
> 
> *******************************************
> Richard A. Sitze            rsitze@us.ibm.com
> 
> 
> 
> 
>                                                               
>                                                    
>                       Tom Jordahl                             
>                                                    
>                       <tomj@macromedia         To:      
> "'axis-dev@xml.apache.org'" <axis-dev@xml.apache.org>    
>                       .com>                    cc:            
>                                                    
>                                                Subject: RE: 
> cvs commit: xml-axis/java/src/org/apache/axis        
>                       05/09/2002 01:18         
> FaultableHandle      r.java                                       
>                       PM                                      
>                                                    
>                       Please respond                          
>                                                    
>                       to axis-dev                             
>                                                    
>                                                               
>                                                    
>                                                               
>                                                    
> 
> 
> 
> 
> > Removed NLS from enter/exit log.debug
> 
> While I am +1 to this, this isn't what has been done in the past.
> 
> Russell has argued that IBM puts all messages, even debug, in to the
> message
> file and that Axis should too.
> 
> --
> Tom Jordahl
> 
> 
> -----Original Message-----
> From: rsitze@apache.org [mailto:rsitze@apache.org]
> Sent: Thursday, May 09, 2002 2:15 PM
> To: xml-axis-cvs@apache.org
> Subject: cvs commit: xml-axis/java/src/org/apache/axis
> FaultableHandler.java
> 
> 
> rsitze      02/05/09 11:14:49
> 
>   Modified:    java/src/org/apache/axis FaultableHandler.java
>   Log:
>   Removed NLS from enter/exit log.debug
>   Logged wrapped exception as info instead of error, as per 
> guidelines.
> 
>   Revision  Changes    Path
>   1.34      +5 -5
> xml-axis/java/src/org/apache/axis/FaultableHandler.java
> 
>   Index: FaultableHandler.java
>   ===================================================================
>   RCS file:
> /home/cvs/xml-axis/java/src/org/apache/axis/FaultableHandler.java,v
>   retrieving revision 1.33
>   retrieving revision 1.34
>   diff -u -r1.33 -r1.34
>   --- FaultableHandler.java          25 Feb 2002 17:38:14 -0000
> 1.33
>   +++ FaultableHandler.java          9 May 2002 18:14:49 -0000
> 1.34
>   @@ -103,12 +103,12 @@
>         * and already done its fault processing - as needed.
>         */
>        public void invoke(MessageContext msgContext) throws 
> AxisFault {
>   -        log.debug(JavaUtils.getMessage("enter00",
> "FaultableHandler::invoke"));
>   +        log.debug("Enter: FaultableHandler::invoke");
>            try {
>                workHandler.invoke( msgContext );
>            }
>            catch( Exception e ) {
>   -            log.error( JavaUtils.getMessage("exception00"), e );
>   +            log.info(JavaUtils.getMessage("toAxisFault00"), e );
>                AxisFault fault = AxisFault.makeFault(e);
> 
>                AxisEngine engine = msgContext.getAxisEngine();
>   @@ -146,16 +146,16 @@
>                    throw fault;
>                }
>            }
>   -        log.debug(JavaUtils.getMessage("exit00",
> "FaultableHandler::invoke"));
>   +        log.debug("Exit: FaultableHandler::invoke");
>        }
> 
>        /**
>         * Some handler later on has faulted so we need to process the
> fault.
>         */
>        public void onFault(MessageContext msgContext) {
>   -        log.debug(JavaUtils.getMessage("enter00",
> "FaultableHandler::onFault"));
>   +        log.debug("Enter: FaultableHandler::onFault");
>            workHandler.onFault( msgContext );
>   -        log.debug(JavaUtils.getMessage("exit00",
> "FaultableHandler::onFault"));
>   +        log.debug("Exit: FaultableHandler::onFault");
>        };
> 
>        public boolean canHandleBlock(QName qname) {
> 
> 
> 
> 
> 
>