axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Jordahl <t...@macromedia.com>
Subject RE: cvs commit: xml-axis/java/src/org/apache/axis/providers/java JavaProvider.java
Date Fri, 10 May 2002 16:16:23 GMT

I'll just say that I had these changes ready to go earlier this week but I did not check them
in because Richard objected (I guess on IRC).  He seemed to feel pretty strongly about it
and I was unable to convince him this was the right thing to do.

--
Tom Jordahl
Macromedia


-----Original Message-----
From: butek@apache.org [mailto:butek@apache.org]
Sent: Friday, May 10, 2002 12:07 PM
To: xml-axis-cvs@apache.org
Subject: cvs commit: xml-axis/java/src/org/apache/axis/providers/java
JavaProvider.java


butek       02/05/10 09:06:30

  Modified:    java/src/org/apache/axis/client AxisClient.java
               java/src/org/apache/axis/handlers JWSProcessor.java
               java/src/org/apache/axis/providers/java JavaProvider.java
  Log:
  Change a few (the ones that affect build output) exception loggings from
  log.info to log.debug.  According to the Developer's Guide:
  
  info - Interesting runtime events (startup/shutdown). Expect these to be
            immediately visible on a console, so be conservative and keep to a minimum.
            These MUST be internationalized.
  
  debug - detailed information on flow of through the system. Expect these to be
            written to logs only. These NEED NOT be internationalized, but it never hurts...
  
  According to this criteria, sounds to me like ALL "catch/throw other"
  exceptions should be logged with debug, not info.  But I'll stick with just
  the ones that affect the build for now.
  
  Revision  Changes    Path
  1.44      +1 -1      xml-axis/java/src/org/apache/axis/client/AxisClient.java
  
  Index: AxisClient.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/client/AxisClient.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- AxisClient.java	9 May 2002 18:20:16 -0000	1.43
  +++ AxisClient.java	10 May 2002 16:06:30 -0000	1.44
  @@ -192,7 +192,7 @@
   
           } catch( Exception e ) {
               // Should we even bother catching it ?
  -            log.info(JavaUtils.getMessage("exception00"), e);
  +            log.debug(JavaUtils.getMessage("exception00"), e);
               throw AxisFault.makeFault(e);
   
           } finally {
  
  
  
  1.46      +1 -1      xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java
  
  Index: JWSProcessor.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- JWSProcessor.java	9 May 2002 18:25:17 -0000	1.45
  +++ JWSProcessor.java	10 May 2002 16:06:30 -0000	1.46
  @@ -289,7 +289,7 @@
               rpc.cleanup();  // ??
           }
           catch( Exception e ) {
  -            log.info(JavaUtils.getMessage("toAxisFault00"), e );
  +            log.debug(JavaUtils.getMessage("toAxisFault00"), e );
               throw AxisFault.makeFault(e);
           }
   
  
  
  
  1.53      +1 -1      xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java
  
  Index: JavaProvider.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- JavaProvider.java	9 May 2002 18:25:18 -0000	1.52
  +++ JavaProvider.java	10 May 2002 16:06:30 -0000	1.53
  @@ -311,7 +311,7 @@
               }
           }
           catch( Exception exp ) {
  -            log.info( JavaUtils.getMessage("toAxisFault00"), exp);
  +            log.debug( JavaUtils.getMessage("toAxisFault00"), exp);
               throw AxisFault.makeFault(exp);
           }
           
  
  
  

Mime
View raw message