Return-Path: Delivered-To: apmail-xml-axis-dev-archive@xml.apache.org Received: (qmail 14071 invoked by uid 500); 14 Mar 2002 15:01:24 -0000 Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@xml.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list axis-dev@xml.apache.org Received: (qmail 14062 invoked from network); 14 Mar 2002 15:01:24 -0000 Subject: RE: [PATCH] MessageElement value serialization, etc To: axis-dev@xml.apache.org X-Mailer: Lotus Notes Release 5.0.7 March 21, 2001 Message-ID: From: "Glyn Normington" Date: Thu, 14 Mar 2002 15:03:37 +0000 X-MIMETrack: Serialize by Router on d06ml007/06/M/IBM(Release 5.0.9a |January 7, 2002) at 14/03/2002 15:01:14 MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N >>1. I re-introduced SOAPHeader.outputImpl as the build failed without it. >It looks like you did not add the change to output() and outputImpl() in >MessageElement. They contained proper code for serializing values, as well a >fix for serializing child elements. The diff of your file against the base was too large, so I resorted to eye-balling and clearly missed this. I'll try to add it back. >>3. I made setObjectValue protected as we don't want to encourage the >>setting of the value by arbitrary classes. >I was thinking of it, as a required public function. There is no other way >to construct simple XML for a Header/Body element. The problem is that the value set by setObjectValue may bear no resemblance to the contents of the element, so I'm afraid I'm not comfortable with committing that as a public function. What do others think? Glyn