axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glyn Normington" <>
Subject RE: [PATCH] MessageElement value serialization, etc
Date Thu, 14 Mar 2002 15:03:37 GMT

>>1. I re-introduced SOAPHeader.outputImpl as the build failed without it.
>It looks like you did not add the change to output() and outputImpl() in
>MessageElement. They contained proper code for serializing values, as well
>fix for serializing child elements.
The diff of your file against the base was too large, so I resorted to
eye-balling and clearly missed this. I'll try to add it back.

>>3. I made setObjectValue protected as we don't want to encourage the
>>setting of the value by arbitrary classes.
>I was thinking of it, as a required public function. There is no other way
>to construct simple XML for a Header/Body element.
The problem is that the value set by setObjectValue may bear no resemblance
to the contents of the element, so I'm afraid I'm not comfortable with
committing that as a public function. What do others think?


View raw message