axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "R J Scheuerle Jr" <>
Subject Re: [AXIS - PATCH] More logging changes
Date Wed, 20 Feb 2002 19:18:27 GMT
Looks great!  Thanks Richard.

Could you explain why the extra jar file is needed.

I can't seem to view diffs.txt.  I am assuming that only the src tree is
affected. (?)

Russell or I will commit the patch once we get some +1's from the rest of
the community.


Rich Scheuerle
XML & Web Services Development
512-838-5115  (IBM TL 678-5115)

                      Sitze/Charlotte/I        To:         
                      BM@IBMUS                 cc:                                       
                                               Subject:  [AXIS - PATCH] More logging changes
                      02/20/2002 11:27                                                   
                      Please respond to                                                  

Some of these may be more controversial, so I'd appreciate a review by
interested parties before anyone applies the patch (diff -u, right?).

(See attached file: diffs.txt)

Summary of changes:

0.  Everyone needs to learn how to edit/override rather
than writing code with System.out.println....  The tests will fail for most
such code.

1.  New jar file, only needed for test (doesn't need to be distributed).

to be added in new directory test/lib:  (See attached file:

2.  test/utils/ is a "check-in" test that verifies
aspects of the source code.  It has been changed to use a list of triplets:
regex (Perl5) filename, regex file-content, and content-match flag (should
or shouldn't be in file...).  Matching names and content generate an error.
It currently looks for:
    -  direct use of log4j (error)
    -  use of System.out.println or System.err.println.  Eexceptions are,, client/,
providers/,, and all tooling in wsdl.

3.  Outside of the listed exceptions, I've removed use of
System.out.println or System.err.println and replaced with,
log.debug, or log.error as seemed appropriate (thereby allowing test to
pass :-).

4.  To facilitate output that USE to appear, I've changed the log4j
properties file to allow INFO, ERROR, and FATAL log messages to be dumped
to the console.... of course we see even more now.

Richard A. Sitze  
CORBA Interoperability & WebServices
IBM WebSphere Development

#### diffs.txt has been removed from this note on February 20 2002 by R J
Scheuerle Jr
#### jakarta-oro-2.0.5.jar has been removed from this note on February 20
2002 by R J Scheuerle Jr

View raw message