axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glyn Normington" <glyn_norming...@uk.ibm.com>
Subject [TEST] SimpleChain unit testcase
Date Fri, 04 Jan 2002 16:34:30 GMT
Please would someone commit this for me? The testcase make sure that
SimpleChain throws an exception if addHandler is called after invoke - to
nail down the behaviour introduced by one of my earlier patches and
stimulate scrutiny if the behaviour is changed.

I couldn't figure out what options to use on cvs diff on linux to include
the new file in patch format (if anyone knows, I'd love to know!), so I've
just appended the file below.

Glyn

Here's the new file contents. It needs to go in
xml-axis/java/test/chains/TestSimpleChain.java. I presume the copyright
date is 2002 since I wrote it today.
------------8<---------------
/*
 * The Apache Software License, Version 1.1
 *
 *
 * Copyright (c) 2002 The Apache Software Foundation.  All rights
 * reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 *
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in
 *    the documentation and/or other materials provided with the
 *    distribution.
 *
 * 3. The end-user documentation included with the redistribution,
 *    if any, must include the following acknowledgment:
 *       "This product includes software developed by the
 *        Apache Software Foundation (http://www.apache.org/)."
 *    Alternately, this acknowledgment may appear in the software itself,
 *    if and wherever such third-party acknowledgments normally appear.
 *
 * 4. The names "Axis" and "Apache Software Foundation" must
 *    not be used to endorse or promote products derived from this
 *    software without prior written permission. For written
 *    permission, please contact apache@apache.org.
 *
 * 5. Products derived from this software may not be called "Apache",
 *    nor may "Apache" appear in their name, without prior written
 *    permission of the Apache Software Foundation.
 *
 * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
 * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
 * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 * SUCH DAMAGE.
 * ====================================================================
 *
 * This software consists of voluntary contributions made by many
 * individuals on behalf of the Apache Software Foundation.  For more
 * information on the Apache Software Foundation, please see
 * <http://www.apache.org/>.
 */
package test.chains;

import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;

import org.apache.axis.SimpleChain;
import org.apache.axis.Handler;
import org.apache.axis.handlers.BasicHandler;
import org.apache.axis.MessageContext;
import org.apache.axis.AxisFault;

public class TestSimpleChain extends TestCase
{
    public TestSimpleChain (String name) {
        super(name);
    }

    public static Test suite() {
        return new TestSuite(TestSimpleChain.class);
    }

    protected void setup() {
    }

    private class TestHandler extends BasicHandler {
        public TestHandler() {}
        public void invoke(MessageContext msgContext) throws AxisFault {}
        public void undo(MessageContext msgContext) {}
    }

    public void testSimpleChainAddHandler()
    {
        SimpleChain c = new SimpleChain();

        Handler h1 = new TestHandler();
        assertTrue("Empty chain has a handler", !c.contains(h1));

        c.addHandler(h1);
        assertTrue("Added handler not in chain", c.contains(h1));
    }

    public void testSimpleChainAddHandlerAfterInvoke()
    {
        try {
            SimpleChain c = new SimpleChain();
            Handler h1 = new TestHandler();
            c.addHandler(h1);

            // A null engine is good enough for this test
            MessageContext mc = new MessageContext(null);
            c.invoke(mc);

            try {
                Handler h2 = new TestHandler();
                c.addHandler(h2);
                assertTrue("Handler added after chain invoked", false);
            } catch (Exception e) {
                // Correct behaviour. Exact exception isn't critical
            }
        } catch (AxisFault af) {
            assertTrue("Unexpected exception", false);
        }
    }
}
------------8<---------------

and the rest in patch format. I've agreed this with Sam, although there is
a mystery about why category.fatal halts the unit test (e.g. under ant
clean all) instead of just logging.

Index: xml-axis/java/src/org/apache/axis/InternalException.java
===================================================================
RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/InternalException.java,v
retrieving revision 1.1
diff -u -r1.1 InternalException.java
--- xml-axis/java/src/org/apache/axis/InternalException.java      23 Dec 2001 12:33:31 -0000
   1.1
+++ xml-axis/java/src/org/apache/axis/InternalException.java      4 Jan 2002 16:18:09 -0000
@@ -62,7 +62,7 @@
 /**
  * Encapsulates exceptions for "should never occur" situations.  Extends
  * RuntimeException so it need not explicitly be caught.  Logs the exception
- * as a fatal error, and if debug is enabled, includes the full stack trace.
+ * as an error, and if debug is enabled, includes the full stack trace.
  *
  * @author Sam Ruby (rubys@us.ibm.com)
  * @author Glyn Normington (glyn_normington@uk.ibm.com)
@@ -91,7 +91,7 @@
         // if the exception is merely bubbling up the stack, only log the
         // event if debug is turned on.
         if (!(e instanceof InternalException)) {
-            category.fatal(e);
+            category.error(e);
         } else {
             category.debug(e);
         }


Mime
View raw message