Return-Path: Delivered-To: apmail-xml-axis-dev-archive@xml.apache.org Received: (qmail 7935 invoked by uid 500); 14 Dec 2001 00:49:59 -0000 Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@xml.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list axis-dev@xml.apache.org Received: (qmail 7926 invoked from network); 14 Dec 2001 00:49:59 -0000 Message-ID: From: "Sedukhin, Igor" To: axis-dev@xml.apache.org Subject: [FIX]: WSDDService/WSDDDeployableItem.makeNewInstance do not name the service instance Date: Thu, 13 Dec 2001 19:49:55 -0500 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2655.55) Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01C18439.3F52D05E" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. ------_=_NextPart_001_01C18439.3F52D05E Content-Type: text/plain I have come across a bug when trying to use SOAPService.getName (or any Handler.getName). It is always null. In fact it has always been null, but after a while it becomes annoying to fix it in the application code all the time. Following is the CVS diff for the fix. Actually all cases of makeNewInstance need this fix, including top WSDDDeployableItem. The CVS diff is included too. This one manifests itself in a really ugly way when I'd try to service.getPivotHandler().getName().equals(...), I obviously get null ptr exception. Somehow this one used to work in alpha2. Please review the fixes and possibly commit them. Thanks. This is a post-alpha2 roadblock again :). !!Another point is that String should really be replaced by QName in case of Handler.getName and setName. It would require matching changes in several other places in Axis. I think it is worth it, but can be done later when really needed. I don't see any problems for Axis in doing that. It is internal Axis business. What does community think about this proposed change? =================================================================== RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDService.java,v retrieving revision 1.26 diff -r1.26 WSDDService.java 208a209 > service.setName(getQName().getLocalPart()); =================================================================== RCS file: /home/cvspublic/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java,v retrieving revision 1.21 diff -r1.21 WSDDDeployableItem.java 319a320 > h.setName(getQName().getLocalPart()); -- Igor Sedukhin .. (Igor.Sedukhin@ca.com) -- (631) 342-4325 .. 1 CA Plaza, Islandia, NY 11788 ------_=_NextPart_001_01C18439.3F52D05E Content-Type: text/html Content-Transfer-Encoding: quoted-printable [FIX]: WSDDService/WSDDDeployableItem.makeNewInstance do not = name the service instance

I have come across a bug when trying = to use SOAPService.getName (or any Handler.getName). It is always null. = In fact it has always been null, but after a while it becomes annoying = to fix it in the application code all the time. Following is the CVS = diff for the fix.

Actually all cases of makeNewInstance = need this fix, including top WSDDDeployableItem. The CVS diff is = included too.
This one manifests itself in a really = ugly way when I'd try to = service.getPivotHandler().getName().equals(...), I obviously get null = ptr exception. Somehow this one used to work in alpha2.

Please review the fixes and possibly = commit them. Thanks.
This is a post-alpha2 roadblock again = :).

!!Another point is that String should = really be replaced by QName in case of Handler.getName and setName. It = would require matching changes in several other places in Axis. I think = it is worth it, but can be done later when really needed. I don't see = any problems for Axis in doing that. It is internal Axis business. What = does community think about this proposed change?

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: = /home/cvspublic/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDSe= rvice.java,v
retrieving revision 1.26
diff -r1.26 = WSDDService.java
208a209
>         = service.setName(getQName().getLocalPart());

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: = /home/cvspublic/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDe= ployableItem.java,v
retrieving revision 1.21
diff -r1.21 = WSDDDeployableItem.java
319a320
>          &nb= sp;      = h.setName(getQName().getLocalPart());



-- Igor Sedukhin .. (Igor.Sedukhin@ca.com)
-- (631) 342-4325 .. 1 CA Plaza, Islandia, NY = 11788


------_=_NextPart_001_01C18439.3F52D05E--