axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sedukhin, Igor" <Igor.Seduk...@ca.com>
Subject RE: WSDD handlers/services without a name
Date Tue, 18 Dec 2001 02:06:03 GMT
Dug,

Thanks. You're right about unnamed handlers. Now I see it in the requestFlow definition. It
would make sense to have them without a name and with only a type.

Well, with all the recent fixes I can, at least, get back the name for the handlers/services
that I have named explicitly. That helps :).

I guess my only worry for now will be being able to get the handler correlated back to the
deployment item in the registry (using Qname as a key, if available).


-- Igor Sedukhin .. (Igor.Sedukhin@ca.com)
-- (631) 342-4325 .. 1 CA Plaza, Islandia, NY 11788



-----Original Message-----
From: Doug Davis [mailto:dug@us.ibm.com] 
Sent: Monday, December 17, 2001 7:18 PM
To: axis-dev@xml.apache.org
Subject: RE: WSDD handlers/services without a name


I believe the original intent was to allow "anonymous" handler - in other words, a handler
that is pretty much just defined for "this" chain. I think its just a short-cut so you don't
have to define it separately from its use.  Just a guess though. -Dug


"Sedukhin, Igor" <Igor.Sedukhin@ca.com> on 12/17/2001 01:44:17 PM

Please respond to axis-dev@xml.apache.org

To:   axis-dev@xml.apache.org
cc:
Subject:  RE: WSDD handlers/services without a name



Dug has promptly fixed the problem detected by junit tests.

I was trying to understand how is it possible to have an unnamed WSDDDeployableItem/WSDDService.
Apparently the it is the org.apache.axis.client that deploys an unnamed service/handler (depending
on the tests).

WSDD schema allows unnamed handlers/services to be deployed. Well, I wasn't sure how much
sense that would make. How can anyone make use of an unnamed WSDDDeployableItem in the registry?
It cannot be referenced in a request flow/chain. It cannot be exposed as a service (as Axis
won't see it). It cannot be used by a client in the Call.invoke sequence. Basically it will
be a stale object right there.

Since the WSDD schema as well as org.apache.axis.deployment.wsdd APIs allow unnamed deployable
items, it leaves a hole for Axis users to make mistakes that would be very hard to trace (due
to Class.makeInstance indirection used in Axis processing pipeline and deployment coordination).

Could someone help me understand why name attribute is optional for WSDD deployable items?
I could certainly be missing some original design incentives. Or otherwise, would anyone agree
that the WSDD deployment APIs and WSDD schema have to be changed to make name attribute mandatory?

PS. To clarify, my objective so far was to make Axis APIs cleaner, more consistent and less
error prone.

-- Igor Sedukhin .. (Igor.Sedukhin@ca.com)
-- (631) 342-4325 .. 1 CA Plaza, Islandia, NY 11788



-----Original Message-----
From: Sam Ruby [mailto:rubys@us.ibm.com]
Sent: Saturday, December 15, 2001 2:38 PM
To: axis-dev@xml.apache.org
Subject: Re: cvs commit: xml-axis/java/src/org/apache/axis/deployment/wsdd
WSDDDeployableItem.java WSDDService.java


This first change below is the cause for the gump reported junit failure.

Glen, Igor: can you check into this?

- Sam Ruby

 = = = = = = = = = = = = = = = = =

gdaniels    01/12/14 13:11:52

  Modified:    java/src/org/apache/axis/deployment/wsdd
                        WSDDDeployableItem.java WSDDService.java
  Log:
  Correctly set the name of deployed Handlers/Services.

  Submitted by Igor Sedukhin <Igor.Sedukhin@ca.com>.

  Revision  Changes    Path
  1.22      +1 -0
xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java

  Index: WSDDDeployableItem.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java,v

  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- WSDDDeployableItem.java 2001/12/06 16:55:43  1.21
  +++ WSDDDeployableItem.java 2001/12/14 21:11:52  1.22
  @@ -317,6 +317,7 @@
               h = (Handler)createInstance(c);

               if (h != null) {
  +                h.setName(getQName().getLocalPart());
                   h.setOptions(getParametersTable());
               }
           } else {



  1.27      +1 -0
xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDService.java

  Index: WSDDService.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDService.java,v

  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- WSDDService.java   2001/11/26 00:58:35  1.26
  +++ WSDDService.java   2001/12/14 21:11:52  1.27
  @@ -206,6 +206,7 @@
           }

           SOAPService   service  = new SOAPService();
  +        service.setName(getQName().getLocalPart());
           service.setOptions(getParametersTable());

           WSDDChain     request  = getRequestFlow();






Message-ID: <OF19A51917.46D13B21-ON85256B23.0067DA81@raleigh.ibm.com>
From: Sam Ruby <rubys@us.ibm.com>
Reply-To: axis-dev@xml.apache.org
To: axis-dev@xml.apache.org
Subject: Re: cvs commit: xml-axis/java/src/org/apache/axis/deployment/wsdd
 WSDDDeployableItem.java WSDDService.java
Date: Sat, 15 Dec 2001 14:38:16 -0500
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2655.55)
List-Help: <mailto:axis-dev-help@xml.apache.org>
List-Unsubscribe: <mailto:axis-dev-unsubscribe@xml.apache.org>
Content-Type: text/plain

This first change below is the cause for the gump reported junit failure.

Glen, Igor: can you check into this?

- Sam Ruby

 = = = = = = = = = = = = = = = = =

gdaniels    01/12/14 13:11:52

  Modified:    java/src/org/apache/axis/deployment/wsdd
                        WSDDDeployableItem.java WSDDService.java
  Log:
  Correctly set the name of deployed Handlers/Services.

  Submitted by Igor Sedukhin <Igor.Sedukhin@ca.com>.

  Revision  Changes    Path
  1.22      +1 -0
xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java

  Index: WSDDDeployableItem.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java,v

  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- WSDDDeployableItem.java 2001/12/06 16:55:43  1.21
  +++ WSDDDeployableItem.java 2001/12/14 21:11:52  1.22
  @@ -317,6 +317,7 @@
               h = (Handler)createInstance(c);

               if (h != null) {
  +                h.setName(getQName().getLocalPart());
                   h.setOptions(getParametersTable());
               }
           } else {



  1.27      +1 -0
xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDService.java

  Index: WSDDService.java
  ===================================================================
  RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDService.java,v

  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- WSDDService.java   2001/11/26 00:58:35  1.26
  +++ WSDDService.java   2001/12/14 21:11:52  1.27
  @@ -206,6 +206,7 @@
           }

           SOAPService   service  = new SOAPService();
  +        service.setName(getQName().getLocalPart());
           service.setOptions(getParametersTable());

           WSDDChain     request  = getRequestFlow();







Mime
View raw message