axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Davis" <...@us.ibm.com>
Subject Re: cvs commit: xml-axis/java/src/org/apache/axis/utils/cache JavaMethod.java
Date Tue, 05 Jun 2001 06:38:12 GMT
To say that we'll match on # of args but then never use the # of args
when the name is unique was wrong to me.  Granted a check for
null would be nice, but I still think it needs to check # of args
since the soap-env might have a different # of args than
the java method and this search will match on it -which is
wrong.
-Dug

Sam Ruby/Raleigh/IBM@IBMUS on 06/04/2001 08:09:08 PM

Please respond to axis-dev@xml.apache.org

To:   axis-dev@xml.apache.org
cc:
Subject:  Re: cvs commit: xml-axis/java/src/org/apache/axis/utils/cache
      JavaMethod.java



dug:
>
> ===================================================================
> RCS file:
/home/cvs/xml-axis/java/src/org/apache/axis/utils/cache/JavaMethod.java,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- JavaMethod.java    2001/05/22 18:42:41  1.2
> +++ JavaMethod.java    2001/06/02 16:02:21  1.3
> @@ -120,7 +120,8 @@
>                  }
>              }
>          }
> -
> +        if ( unique.getParameterTypes().length != numargs )
> +          return null ;
>          return unique;
>      }
>  };

-1.

First, unique may be null.

Second, the functional description of this method is as follows:
    /**
     * Attempt to find the closest matching method based on the number
     * of arguments only.  Note: if there are multiple matches, one
     * will be picked randomly.  If the name is unique, it is simply
     * returned without checking as attempts to invoke a method based
     * on this will undoubtably fail anyway.
     * @param numargs number of arguments
     * @return closest match
     */

Third, RPCElement.java depends on the function working as specified.

- Sam Ruby




Mime
View raw message