Mailing-List: contact axis-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@xml.apache.org
Date: Fri, 25 May 2001 19:38:10 -0700
From: Rob Jellinghaus <robj@unrealities.com>
Subject: Re: Random formatting questions
In-reply-to: <013101c0e588$619547a0$ce00a8c0@rubypad>
To: axis-dev@xml.apache.org, axis-dev@xml.apache.org
Message-id: <3.0.1.32.20010525193810.0123ca98@shell2.ba.best.com>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
References: <3.0.1.32.20010525184916.0123c958@shell2.ba.best.com>
 <046f01c0e586$559db0b0$0600a8c0@dugpad1>

>From The Java Code Conventions:
"Four spaces should be used as the unit of indentation."

I wondered about this, as *many* files in the system have a tab size of
two.  (I actually prefer two myself, but I will defer to the standard
here.)  What I really don't like is inconsistency, but c'est la vie.

I am currently refactoring handlers/MsgDispatchHandler.java and
handlers/RPCDispatchHandler.java into providers/java/JavaProvider.java
(base class), and providers/java/MsgProvider.java &
providers/java/RPCProvider.java (subclasses).  This is to eliminate the
duplicate code between the dispatch handlers (while adding uniform session
support to both), and to start fleshing out the provider stuff.  It's a
substantial enough rewrite to be worth a reindent :-)

Cheers,
Rob

At 10:05 PM 5/25/2001 -0400, Sam Ruby wrote:
>For new committers, I would recommend taking a look at
>http://xml.apache.org/axis/ref.html.  Search for the word "must".  It
>appears three times.
>
>Some of the old committers seem to not realize that there will be javadocs
>produced.  :-P
>
>P.S.  I agree with Doug about no tabs and please only reformat if you do a
>significant rewite.  But if you do reformat, please consider the "musts"
>above.
>
>
>