Return-Path: Delivered-To: apmail-ws-axis-c-user-archive@www.apache.org Received: (qmail 55777 invoked from network); 31 Jul 2008 21:56:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 31 Jul 2008 21:56:24 -0000 Received: (qmail 75780 invoked by uid 500); 31 Jul 2008 21:56:23 -0000 Delivered-To: apmail-ws-axis-c-user-archive@ws.apache.org Received: (qmail 75768 invoked by uid 500); 31 Jul 2008 21:56:23 -0000 Mailing-List: contact axis-c-user-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: "Apache AXIS C User List" Reply-To: "Apache AXIS C User List" Delivered-To: mailing list axis-c-user@ws.apache.org Received: (qmail 75753 invoked by uid 99); 31 Jul 2008 21:56:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2008 14:56:23 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.68.5.15] (HELO relay01.pair.com) (209.68.5.15) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 31 Jul 2008 21:55:25 +0000 Received: (qmail 34324 invoked from network); 31 Jul 2008 21:55:50 -0000 Received: from unknown (HELO ?192.168.1.100?) (unknown) by unknown with SMTP; 31 Jul 2008 21:55:50 -0000 X-pair-Authenticated: 69.107.13.76 Message-ID: <489234E3.7040802@wso2.com> Date: Fri, 01 Aug 2008 03:25:47 +0530 From: Samisa Abeysinghe User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Apache AXIS C User List Subject: Re: Memory leak report for Axis2c 1.4 References: <014C756DD244D34991AEE9B9CC54A62909ECF17B@serv105.ARGO.LOCAL> In-Reply-To: <014C756DD244D34991AEE9B9CC54A62909ECF17B@serv105.ARGO.LOCAL> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org You could have a look at the rationale by looking at the svn log for that change. http://svn.apache.org/viewvc/webservices/axis2/trunk/c/ Thanks, Samisa... Hatim Daginawala wrote: > I have tried and it seems to be working for my test program. However, I > would like to understand why the code was commented out. That may help > me evaluate the risk. > > Thanks > > -----Original Message----- > From: Samisa Abeysinghe [mailto:samisa@wso2.com] > Sent: Thursday, July 31, 2008 4:12 PM > To: Apache AXIS C User List > Subject: Re: Memory leak report for Axis2c 1.4 > > Hatim Daginawala wrote: > >> Is it safe to uncomment AXIS2_FREE call to avoid memory leaks? >> >> > > You can try :) > > Samisa... > > >> >> >> This leak still exists in 1.5 also. >> >> >> >> >> > ------------------------------------------------------------------------ > >> *From:* Milinda Pathirage [mailto:milinda.pathirage@gmail.com] >> *Sent:* Thursday, May 15, 2008 10:01 PM >> *To:* Apache AXIS C User List >> *Subject:* Re: Memory leak report for Axis2c 1.4 >> >> >> >> Hi all, >> I think this leak only exists in Windows. This is caused by following >> code. >> >> #ifdef WIN32 >> attr_name_str = axutil_string_create(env, attr_name); >> axiom_xml_reader_xml_free(om_builder->parser, env, attr_name); >> #else >> >> There are so many places in om_stax_builder.c where we have used above >> > > >> kind of logic. Because we have comment out the reported code block: >> >> void AXIS2_CALL >> guththila_xml_reader_wrapper_xml_free( >> axiom_xml_reader_t * parser, >> const axutil_env_t * env, >> void *data) >> { >> /*if (data) >> AXIS2_FREE(env->allocator, data); */ >> } >> >> in guththila wrapper, it caused memory leaks in windows but not in >> > Linux. > >> Thanks >> Milinda. >> >> On Fri, May 16, 2008 at 4:04 AM, Samisa Abeysinghe > > wrote: >> >> Steven Zhang wrote: >> >> Hi: >> I just finded memory leak in Axis2 1.4 GUTHTHILA: >> 1. guththila_xml_read_wrapper.c: >> guththila_xml_reader_wrapper_xml_free(), line 581, call to >> AXIS2_FREE() for string buffer was commented, cause tens K memory leak >> > > >> for each request. Why this one is commented? >> >> 2. guththila_xml_writer.c: >> guththila_write_empty_element_with_prefix_and_namespace(), line 1694. >> When nmsp_found is FALSE, namesp pointer will be pushed into stack, >> however when it's FALSE, namesp pointer will not be used and not be >> > freed. > >> >> >> I thought we fixed all the leaks before the release. What is the code >> you are using to test for leaks? Did you try with echo sample? >> >> Samisa... >> >> >> Am I correct? >> >> Thanks. >> Steven Zhang >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: axis-c-user-unsubscribe@ws.apache.org >> >> For additional commands, e-mail: axis-c-user-help@ws.apache.org >> >> >> >> > ------------------------------------------------------------------------ > >> No virus found in this incoming message. >> Checked by AVG. Version: 8.0.100 / Virus Database: 269.23.16/1434 - >> Release Date: 5/15/2008 7:24 AM >> >> >> >> >> -- >> Samisa Abeysinghe Director, Engineering; WSO2 Inc. >> >> http://www.wso2.com/ - "The Open Source SOA Company" >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: axis-c-user-unsubscribe@ws.apache.org >> >> For additional commands, e-mail: axis-c-user-help@ws.apache.org >> >> >> >> >> >> -- >> http://inf-dimensions.blogspot.com "Infinite Dimensions" >> http://wsaxc.blogspot.com "Web Services With Axis2/C" >> >> >> > ------------------------------------------------------------------------ > >> --------------------------------------------------- >> Confidentiality Notice: This electronic mail transmission is >> confidential, >> may be privileged and should be read or retained only by the intended >> recipient. If you have received this transmission in error, please >> immediately notify the sender and delete it from your system. >> No virus found in this incoming message. >> Checked by AVG - http://www.avg.com >> Version: 8.0.138 / Virus Database: 270.5.7/1581 - Release Date: >> > 7/30/2008 6:56 AM > >> >> > > > -- Samisa Abeysinghe Director, Engineering; WSO2 Inc. http://www.wso2.com/ - "The Open Source SOA Company" --------------------------------------------------------------------- To unsubscribe, e-mail: axis-c-user-unsubscribe@ws.apache.org For additional commands, e-mail: axis-c-user-help@ws.apache.org