axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nadir amra (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2C-976) base64 encode length returns size of encoded string + 1.
Date Wed, 02 Jun 2010 04:42:37 GMT

    [ https://issues.apache.org/jira/browse/AXIS2C-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874414#action_12874414
] 

nadir amra commented on AXIS2C-976:
-----------------------------------

I guess my opinion is to go with precedence....and so whatever Apache APR API does we should
do. 

> base64 encode length returns size of encoded string + 1.
> --------------------------------------------------------
>
>                 Key: AXIS2C-976
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-976
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 1.3.0
>            Reporter: Senaka Fernando
>            Assignee: S.Uthaiyashankar
>             Fix For: 1.7.0
>
>
> base64 encode length returns size of encoded string + 1, which is incorrect. This is
because we assume that someone expects the length + 1 to accommodate '\0' that we add. But,
if we gave the same string to a strlen() it returns size of encoded string. This would confuse
a potential user.
> axutil_base64_encode (encoded, "senaka", 6) = 9, and strlen(encoded) = 8. Also, axutil_base64_encode_len(6)
= 9.
> Therefore, I think it is better to stick to the strlen() way, especially because popular
libraries and resources adopt that strategy. Refer [1] for more information.
> [1] http://www.obviex.com/Articles/CiphertextSize.aspx
> Regards,
> Senaka

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


Mime
View raw message