axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Springer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2C-1470) basic keep-alive support for simple http server + some bugs
Date Tue, 30 Mar 2010 09:16:45 GMT

    [ https://issues.apache.org/jira/browse/AXIS2C-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851329#action_12851329
] 

Robert Springer commented on AXIS2C-1470:
-----------------------------------------

In the proposed solution there are returns without freeing up thread/threa_pool resources
in function axis2_svr_thread_worker_func():

1st modification:

     if(!data)
     {
+#ifdef AXIS2_SVR_MULTI_THREADED
+	axutil_thread_pool_exit_thread(env->thread_pool, thd);
+#endif
         return NULL;
     }

2nd modification:

     if(!svr_conn)
     {
         AXIS2_LOG_ERROR(env->log, AXIS2_LOG_SI, "creating simple_http_svr_connection failed");
+	axutil_free_thread_env(thread_env);
+	thread_env = NULL;
+#ifdef AXIS2_SVR_MULTI_THREADED
+	axutil_thread_pool_exit_thread(env->thread_pool, thd);
+#endif
         return NULL;
     }

3rd modification:

     request = axis2_simple_http_svr_conn_read_request(svr_conn, thread_env);
     if(!request)
     {
	axutil_queue_push(thread_env, unused, svr_conn);
         AXIS2_LOG_ERROR(env->log, AXIS2_LOG_SI, "Could not create request");
	if (!new_conn) {
	  axutil_conn_remove_by_sd(thread_env, connections, socket);
	}
+	axutil_free_thread_env(thread_env);
+	thread_env = NULL;
+#ifdef AXIS2_SVR_MULTI_THREADED
+	axutil_thread_pool_exit_thread(env->thread_pool, thd);
+#endif
         return NULL;
     }



> basic keep-alive support for simple http server + some bugs
> -----------------------------------------------------------
>
>                 Key: AXIS2C-1470
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1470
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: core/transport
>    Affects Versions: 1.7.0
>         Environment: linux
>            Reporter: Robert Springer
>            Priority: Minor
>         Attachments: axis2c.zip, Some problems with axis2c (1.6).txt
>
>
> 1. Basic keep-alive support for simple http server
> 2. Free up accept header field list, accept charset header field list, accept language
header field list
> 3. Removal of uncounted CRLF from the response

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


Mime
View raw message