axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Uthaiyashankar <shan...@wso2.com>
Subject Re: Can I always assume axis2_desc_t children are axis2_msg_t ?
Date Tue, 06 Jan 2009 06:03:24 GMT
On Tue, Jan 6, 2009 at 10:32 AM, Damitha Kumarage <damitha23@gmail.com>wrote:

> Manjula Peiris wrote:
>
>> Hi,
>>
>> While fixing https://issues.apache.org/jira/browse/AXIS2C-1313
>> I came across $subject. Currently axis2_desc_add_child() method call
>> only from op.c. But according to the Axis2 architecture it shouldn't
>> only be axis2_msg_t. WDYT ?
>>
>>
> AFAIK it could be only axis2_msg_t. Perhaps you are wondering why in that
> method signature child is a void pointer without specifically being a
> axis2_msg_t. And as I remember this was originally designed to be used for
> any parent in the description hierarchy to add a child. However it was not
> used in that way.
> So may be to avoid confusion we may pass axis2_msg_t there instead of void
> pointer.


+1. Even when freeing, it is blindly converting the void* ro axis2_msg_t *.
It is better to change it to axis2_msg_t*.

Regards,
Shankar


>
>
> thanks,
> Damitha
>
>> Thanks,
>> -Manjula
>>
>>
>>
>
>
> --
> __________________________________________________________________
>
> Damitha Kumarage
> http://people.apache.org/
> __________________________________________________________________
>



-- 
S.Uthaiyashankar
Software Architect
WSO2 Inc.
http://wso2.com/ - "The Open Source SOA Company"

Mime
View raw message