axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damitha Kumarage (JIRA)" <j...@apache.org>
Subject [jira] Closed: (AXIS2C-1084) Retrieving wrong object in the conf.c code
Date Wed, 04 Jun 2008 06:30:45 GMT

     [ https://issues.apache.org/jira/browse/AXIS2C-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Damitha Kumarage closed AXIS2C-1084.
------------------------------------

    Resolution: Fixed

This is fixed now

> Retrieving wrong object in the conf.c code
> ------------------------------------------
>
>                 Key: AXIS2C-1084
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1084
>             Project: Axis2-C
>          Issue Type: Bug
>            Reporter: Damitha Kumarage
>            Assignee: Damitha Kumarage
>
> I found following error in the conf.c code. Please look at the svn diff with the corrected
code.
> -        axis2_char_t *svc_name2 = NULL;
> +        axis2_svc_t *temp_svc = NULL;
>          const axutil_qname_t *svc_qname = NULL;
>          axutil_hash_this(index_i, NULL, NULL, &value);
> @@ -566,10 +605,10 @@
>          svc_qname = axis2_svc_get_qname(desc, env);
>          svc_name = axutil_qname_get_localpart(svc_qname, env);
> -        svc_name2 = axutil_hash_get(conf->all_svcs, svc_name,
> +        temp_svc = axutil_hash_get(conf->all_svcs, svc_name,
>                                      AXIS2_HASH_KEY_STRING);
> -        /* no two service names deployed in the engine can be same */
> -        if (svc_name2)
> +        /* No two service names deployed in the engine can be same */
> +        if (temp_svc)
>          {
>              AXIS2_ERROR_SET(env->error,
>                              AXIS2_ERROR_TWO_SVCS_CANNOT_HAVE_SAME_NAME,
> What is stored in conf->all_svcs is service description instances. However in the
buggy code we retireve it to a axis2_char_t type which is wrong. However the code worked because
we just check whether the retrieved objec is NULL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message