axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manjula Peiris <manj...@wso2.com>
Subject Re: Refactoring the transport
Date Fri, 27 Jun 2008 02:06:31 GMT

On Thu, 2008-06-26 at 23:57 +0530, Damitha Kumarage wrote:
> Hi Manjula,
> Manjula Peiris wrote:
> > Hi devs,
> >
> > Most of the code in Axis2/C transport is not organized properly. This
> > makes it very difficult to do some changes or adding new functionality
> > to the code. One main reason for this is REST handling and SOAP handling
> > are mixed in the code in a very ugly manner. Axis2/JAVA has a separate
> > section called MessageBuilder which happened before the Transport stuff
> > in order to separate out REST Invocations, SOAP invocations and other
> > different messaging mechanisms. I propose we do something like that or
> > at least separate out REST handling inside HTTP transport.(I mean at
> > least separate REST code to different functions or .c files. ) This can
> > be a post 1.5 fix.
> >   
> Even before the rest stuff added the transport code seemed very complex. 
> One reason
> for it is that because it is working we did not bothered to do any 
> changes or refactoring.
> Even if we were aware of this we did not venture to work on this issue 
> because code is
> highly duplicated among many transports. But sooner or later we need to 
> refactor it.
> So +1 for doing it as post 1.5 fix. Adding comprehensive code comments 
> at the same time
> would be a + point.
> 
> Is MessageBuilder a mechanism to build execution chains?. In Axis2/C we 
> build execution
> chains/flows statically at deployment time using phase info and phase 
> resolver.

No, in the case of HTTP we can differentiate a REST call and SOAP call
from the content-type. So after differentiating this their corresponding
MessageBuilders are invoked prior to engine. 

> 
> thanks,
> Damitha
> > Thanks,
> > -Manjula.   
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >
> >
> >   
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message