axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manjula Peiris <manj...@wso2.com>
Subject Re: [Axis2] mime parser [was: Re: Windows build break]
Date Wed, 20 Feb 2008 14:21:26 GMT

On Wed, 2008-02-20 at 19:11 +0530, Manjula Peiris wrote:
> On Wed, 2008-02-20 at 09:33 +0530, Samisa Abeysinghe wrote:
> > Manjula,
> >     Did you test this with smaller buffer size, no of buffrs vs. larger 
> > file.
> >     I mean 1MB buffer * 2 buffers with a 3MB file?
> 
> In the current implementation it is not handled. I will fix it to put an
> error to the log. since by default the parameters are commented and can
> handle up to 1000MB this won't be a big issue.

Fixed to put an error to the log.

> 
> -Manjula.
> 
> > 
> >     I did not test, but just curious.
> > 
> > Thanks,
> > Samisa...
> > 
> > Manjula Peiris wrote:
> > > Sorry it is my fault. In linux it didn't give any error even with
> > > Werror.
> > >
> > > Fixed it to allocate the two arrays dynamically.
> > >
> > > On Tue, 2008-02-19 at 21:41 +0530, Samisa Abeysinghe wrote:
> > >   
> > >> Samisa Abeysinghe wrote:
> > >>     
> > >>> mime_parser.c
> > >>> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2057: expected

> > >>> constant expression
> > >>> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2466: cannot

> > >>> allocate an array of constant size 0
> > >>> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2133: 
> > >>> 'buf_array' : unknown size
> > >>> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2057: expected

> > >>> constant expression
> > >>> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2466: cannot

> > >>> allocate an array of constant size 0
> > >>> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2133: 
> > >>> 'len_array' : unknown size
> > >>>       
> > >> I also think that there is a logical error in this code:
> > >>
> > >> axis2_char_t *buf_array[mime_parser->max_chunk_buffers];
> > >>     int len_array[mime_parser->max_chunk_buffers];
> > >>
> > >> Should the two arrays be of the size max_chunk_buffers?
> > >>     
> > > Yes , but the thing is max_chunk_buffers is not a constant it is
> > > configurable.
> > >
> > >   
> > >> And the syntax error is because the static variable is declared with 
> > >> variable size. Should use a dynamic allocation.
> > >>     
> > > Changed to use dynamic allocation. Please check now.
> > >
> > >   
> > >> Samisa...
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > >> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> > >>
> > >>     
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> > >
> > >
> > >
> > >   
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message