axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Mitchell (JIRA)" <>
Subject [jira] Updated: (AXIS2C-933) guththila parser does not handle incomplete messages well, leading to an infinite loop or seg fault
Date Mon, 04 Feb 2008 14:45:08 GMT


Bill Mitchell updated AXIS2C-933:

    Attachment: diff2.txt

Supun, I see the cause of the confusion.  When I uploaded a revised version of this patch,
I mistakenly did not strip all the fixes to other modules from this patch.  My bad.  

I've fixed that error in the diff2.txt file, so it is just this fix combined with the fix
already applied later to guththila for AXIS2C-857.  So you can examine this to see if anything
strikes you as really odd.  Later today, I should have a chance to rebuild the patch against
the current guththila_xml_parser.c source, so the patch will then include just this fix and
not AXIS2C-857.  

> guththila parser does not handle incomplete messages well, leading to an infinite loop
or seg fault
> ---------------------------------------------------------------------------------------------------
>                 Key: AXIS2C-933
>                 URL:
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: guththila
>    Affects Versions: Current (Nightly)
>         Environment: Windows XP, Visual Studio 2005, guththila, libcurl
>            Reporter: Bill Mitchell
>         Attachments: diff.txt, diff2.txt
> The code in the guththila parser has a couple of problems when the first allocated buffer
fills up and it attempts to read more data.  First, when allocating another buffer it doubled
the size of all the buffers allocated to this point, but then recorded the new buffer size
as only equal to the size of all the previous buffers.  Second, after fixing the buffer allocation
issue, I discovered that the read into the buffer tried to read as much as all the buffers
to date, instead of just the amount remaining in the buffer just allocated.  There is also
a subtle problem in the guththila_next_no_char routine if last_start is not set, that it did
not assure that all the characters since next are moved to the newly allocated buffer.  
> While debugging this, because of other issues, I walked through the path of an unexpected
EOF in the middle of the incoming message, and discovered that several while loops in the
parser do not stop on EOF, but just keep reading and reading and reading...

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message